Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Jun 2018 15:37:50 -0400
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r334791 - head/share/mk
Message-ID:  <e964ad55-ce4d-b494-40c4-bd387c8619e6@FreeBSD.org>
In-Reply-To: <20180607170552.GB93814@FreeBSD.org>
References:  <201806071616.w57GGMIo017645@repo.freebsd.org> <20180607164420.GA93814@FreeBSD.org> <20180607170552.GB93814@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gFqPze92NHBlzOX8uP1aub0ImdoHUacJw
Content-Type: multipart/mixed; boundary="wlGjwO95dsyQLHP6IkzQpB3flrGRh5ZAQ";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
Message-ID: <e964ad55-ce4d-b494-40c4-bd387c8619e6@FreeBSD.org>
Subject: Re: svn commit: r334791 - head/share/mk
References: <201806071616.w57GGMIo017645@repo.freebsd.org>
 <20180607164420.GA93814@FreeBSD.org> <20180607170552.GB93814@FreeBSD.org>
In-Reply-To: <20180607170552.GB93814@FreeBSD.org>

--wlGjwO95dsyQLHP6IkzQpB3flrGRh5ZAQ
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 6/7/18 1:05 PM, Alexey Dokuchaev wrote:
> On Thu, Jun 07, 2018 at 04:44:20PM +0000, Alexey Dokuchaev wrote:
>> On Thu, Jun 07, 2018 at 04:16:22PM +0000, Bryan Drewery wrote:
>>> New Revision: 334791
>>> URL: https://svnweb.freebsd.org/changeset/base/334791
>>>
>>> Log:
>>>   Stop using head(1) which is not available in installworld.
>>> ...
>>> @@ -49,7 +49,7 @@ ${var}=3D	${${var}.${${X_}_ld_hash}}
>>> =20
>>>  .if ${ld} =3D=3D "LD" || (${ld} =3D=3D "XLD" && ${XLD} !=3D ${LD})
>>>  .if !defined(${X_}LINKER_TYPE) || !defined(${X_}LINKER_VERSION)
>>> -_ld_version!=3D	(${${ld}} --version || echo none) | head -n 1
>>> +_ld_version!=3D	(${${ld}} --version || echo none) | sed -n '1,1p'
>>
>> You don't need to specify the range actually, and the quotes.  Simple
>> `sed -n 1p' looks shorter and does not raise unnecessary questions.

Yup makes sense, thanks.

>=20
> Actually, `sed q' is sufficient.
>=20

I'll stick with -n 1p as I think it is more clear.

> ./danfe
>=20


--=20
Regards,
Bryan Drewery


--wlGjwO95dsyQLHP6IkzQpB3flrGRh5ZAQ--

--gFqPze92NHBlzOX8uP1aub0ImdoHUacJw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlsZiY4ACgkQNddxu25G
l88Pnwf/bpWO+xYmowXZyB7/JpNN5hQw+haC2GZ0Ae5W2ajN2MQ8ocgS80VKCXzU
2dOIe+xafjmlIjHyqJ630/HkPrtSkE7bUmebxWPWKqx7vBeEvn0ARjj9h6g9wLcp
0s0mQu1m+d6xGkX/Johd63B5CACtHjpAdXq+kKFatm/qDXE6Pb3bACAcI27IO/bU
y/y055pK7RHMbjeZC5Tibgn93ICmf7M8qf548g1Tl+2QcDu3xkRKwmkbGEphXIiJ
shfWXeAHnypKj2/Ie56q8zyp+qQ7lJK2n1I2TlDnLNrtY42nCrUwXPRc7i5DLOmj
Qy4Srbzq0gNUbe4ckN+cVNXFzryEsA==
=ej4H
-----END PGP SIGNATURE-----

--gFqPze92NHBlzOX8uP1aub0ImdoHUacJw--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e964ad55-ce4d-b494-40c4-bd387c8619e6>