Date: Thu, 18 Apr 2002 20:05:50 +0900 (JST) From: Keiichi SHIMA / =?iso-2022-jp?B?GyRCRWc3RDBsGyhC?= <keiichi@iij.ad.jp> To: freebsd-net@FreeBSD.ORG Subject: Re: Questions on ip_output.c's patch for FreeBSD-SA-02:21.tcpip Message-ID: <20020418.200550.110156595.keiichi@iij.ad.jp> In-Reply-To: <20020418094722.GG98788@sunbay.com> References: <200204171923.g3HJNg958905@freefall.freebsd.org> <x7vgapxy7o.wl@s30.crl.hitachi.co.jp> <20020418094722.GG98788@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
From: Ruslan Ermilov <ru@FreeBSD.ORG>
> I strongly object to this change. BSD historically didn't allow for
> ip_output() to be called with the NULL route pointer. I changed this
I don't know the history of BSD, but, if the reason is the history
(that BSD didn't allow NULL route), I agree your fix is the only way.
> in rev. 1.143 in a blind attempt to fix a panic condition I introduced
> in ip_icmp.c,v 1.64. Unfortunately, this didn't actually fix the
> ip_icmp.c bug but rather _hided_ it. Many respectful people objected
> to the 1.143 change, including Garrett Wollman, but I didn't realize
> at the time why this was bad. I since have fixed my mind, and I now
> realize why it's bad. The details could be found in the commit log
> for ip_output.c,v 1.153. Hopefully you can follow that.
If the reason is "Prevent icmp_reflect() from calling ip_output() with
a NULL route pointer which will then result in the allocated route's
~~~~~~~~~~~~~~~~~~~~~
reference count never being decremented.", I think both patches can
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fix this problem.
Regards,
---
Keiichi SHIMA
IIJ Research Laboratory <keiichi@iij.ad.jp>
KAME Project <keiichi@kame.net>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020418.200550.110156595.keiichi>