Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Oct 2012 17:42:16 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>
Subject:   Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet
Message-ID:  <20121015144216.GI35915@deviant.kiev.zoral.com.ua>
In-Reply-To: <20121015143658.GU89655@FreeBSD.org>
References:  <201210141503.q9EF37rE087018@svn.freebsd.org> <201210150834.09553.jhb@freebsd.org> <20121015143658.GU89655@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ekB8d505ZB0gDS8i
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 15, 2012 at 06:36:58PM +0400, Gleb Smirnoff wrote:
> On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote:
> J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote:
> J> > Author: glebius
> J> > Date: Sun Oct 14 15:03:06 2012
> J> > New Revision: 241546
> J> > URL: http://svn.freebsd.org/changeset/base/241546
> J> >=20
> J> > Log:
> J> >   Fix defines in r241245. We actually don't define FreeBSD.
> J> >  =20
> J> >   Reported & tested by:	Oleg Ginzburg
> J>=20
> J> Seems like it should be using 'defined(__FreeBSD_version)' instead?
>=20
> AFAIU, the construction which left after r241546 works fine. Anything
> undefined resolves to zero, so in case of non-FreeBSD build we test
> if (0 > 10000019) and this fails which is what we expect.
>=20
> I have used this construction several times already without any side effe=
cts.
> I have also seen it in some software in ports, where it works okay, too.
We do define __FreeBSD__.

--ekB8d505ZB0gDS8i
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAlB8IMgACgkQC3+MBN1Mb4iI/QCfQziwANRcyr+JykDgF34Sve3n
Q9sAn1QnTQPl2OpleQaNdQwhhgRBhQya
=p8ZL
-----END PGP SIGNATURE-----

--ekB8d505ZB0gDS8i--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121015144216.GI35915>