From owner-svn-src-head@FreeBSD.ORG Mon Oct 15 14:42:34 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A5659971; Mon, 15 Oct 2012 14:42:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 01B508FC0C; Mon, 15 Oct 2012 14:42:33 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q9FEgSot058280; Mon, 15 Oct 2012 17:42:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q9FEgGwX015793; Mon, 15 Oct 2012 17:42:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q9FEgGbS015792; Mon, 15 Oct 2012 17:42:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 15 Oct 2012 17:42:16 +0300 From: Konstantin Belousov To: Gleb Smirnoff Subject: Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet Message-ID: <20121015144216.GI35915@deviant.kiev.zoral.com.ua> References: <201210141503.q9EF37rE087018@svn.freebsd.org> <201210150834.09553.jhb@freebsd.org> <20121015143658.GU89655@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ekB8d505ZB0gDS8i" Content-Disposition: inline In-Reply-To: <20121015143658.GU89655@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 14:42:34 -0000 --ekB8d505ZB0gDS8i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 15, 2012 at 06:36:58PM +0400, Gleb Smirnoff wrote: > On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote: > J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote: > J> > Author: glebius > J> > Date: Sun Oct 14 15:03:06 2012 > J> > New Revision: 241546 > J> > URL: http://svn.freebsd.org/changeset/base/241546 > J> >=20 > J> > Log: > J> > Fix defines in r241245. We actually don't define FreeBSD. > J> > =20 > J> > Reported & tested by: Oleg Ginzburg > J>=20 > J> Seems like it should be using 'defined(__FreeBSD_version)' instead? >=20 > AFAIU, the construction which left after r241546 works fine. Anything > undefined resolves to zero, so in case of non-FreeBSD build we test > if (0 > 10000019) and this fails which is what we expect. >=20 > I have used this construction several times already without any side effe= cts. > I have also seen it in some software in ports, where it works okay, too. We do define __FreeBSD__. --ekB8d505ZB0gDS8i Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlB8IMgACgkQC3+MBN1Mb4iI/QCfQziwANRcyr+JykDgF34Sve3n Q9sAn1QnTQPl2OpleQaNdQwhhgRBhQya =p8ZL -----END PGP SIGNATURE----- --ekB8d505ZB0gDS8i--