From owner-svn-src-all@freebsd.org Mon Jul 2 14:56:30 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BDA5102C14D; Mon, 2 Jul 2018 14:56:30 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E6168C636; Mon, 2 Jul 2018 14:56:29 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-ed1-f44.google.com with SMTP id u11-v6so2887961eds.10; Mon, 02 Jul 2018 07:56:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svxX5zzjxTIxZVVlhCTaG6hDgFDBqfSCsSw6Cm3tHMM=; b=Fb0fGG4lLZJbi2K92f+igE4QroRMSKy1PgzQt7+xoIwZzLD78xFqyJi7LWBzQybluu ZwyCOD466106NpEFFtMjIyU/TOMrvC5025PyKP+3WAKv92UBh0awZM/cPN3Vy1fqSopL mnUmemkyU84jQGODjkRzYLGFg4kOxoxrx9kcFHX/5S1zpJoj1GOPf2UmcPdPNxkO3QPS 6CDMTgJedWHSJDsRx3K0GajqHONrSSkU0GiFKeZPCfPjWcYshIaRPqln+IpOmgXL8l17 GokhkyPv5GbV9i+Z1tlAU8EakA4AUBJczsD0Ks1e038sdZpfMd6XTxEVeXroi/PmQspF hxWg== X-Gm-Message-State: APt69E2DcPE9mh1Sqc8DBzqVtRE5Y1yg0h7QSS3L5nrlmpMEkh42ArOT RZ2GJw657ejyQO/bqLpLZS9CWu/G X-Google-Smtp-Source: AAOMgpeJLMpEBaBh++/u7Kq00eTBPQa1Q9cjvw4w2TY4ag6CIybOj26j8/vUWLOo4w1msCLPMLWYOQ== X-Received: by 2002:aa7:d717:: with SMTP id t23-v6mr25076398edq.102.1530543383204; Mon, 02 Jul 2018 07:56:23 -0700 (PDT) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com. [74.125.82.42]) by smtp.gmail.com with ESMTPSA id b3-v6sm7171996edi.60.2018.07.02.07.56.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jul 2018 07:56:22 -0700 (PDT) Received: by mail-wm0-f42.google.com with SMTP id n17-v6so9076157wmh.2; Mon, 02 Jul 2018 07:56:22 -0700 (PDT) X-Received: by 2002:a1c:7a06:: with SMTP id v6-v6mr8500683wmc.90.1530543382391; Mon, 02 Jul 2018 07:56:22 -0700 (PDT) MIME-Version: 1.0 References: <201807020519.w625JinG069138@repo.freebsd.org> In-Reply-To: From: "Jonathan T. Looney" Date: Mon, 2 Jul 2018 10:56:10 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335856 - in head/sys: netinet sys To: steven.hartland@multiplay.co.uk Cc: Matt Macy , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 14:56:30 -0000 On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < steven.hartland@multiplay.co.uk> wrote: > > You have M_WAITOK and a null check in this change And, that's the same as the way it was before his commits. So, he did exactly what he said he was doing and reverted his commits. I don't think it is good practice to mix reverts with other changes. Since you've noticed this, I think you should feel free to make the change. Jonathan