From owner-svn-src-all@freebsd.org Sat Dec 17 14:34:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BCCCC84106; Sat, 17 Dec 2016 14:34:06 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7188793; Sat, 17 Dec 2016 14:34:05 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::e9b4:ef6:9a02:eea4] (unknown [IPv6:2001:7b8:3a7:0:e9b4:ef6:9a02:eea4]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 440B514F74; Sat, 17 Dec 2016 15:34:02 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r310051 - in head: share/man/man9 sys/kern sys/sys From: Dimitry Andric In-Reply-To: Date: Sat, 17 Dec 2016 15:33:55 +0100 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201612141247.uBEClYYq008778@repo.freebsd.org> <7B04505B-6DC1-4020-BC78-D5CC0B6F6B2C@FreeBSD.org> To: Ed Schouten X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 14:34:06 -0000 --Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 17 Dec 2016, at 10:43, Ed Schouten wrote: > > 2016-12-16 23:55 GMT+01:00 Dimitry Andric : >> Since this now causes VMware kernel modules to insta-panic the kernel, >> it might be nice to put some warning in UPDATING, at least. Luckily >> __FreeBSD_version got bumped by Adrian in r310149 for something >> unrelated, but this is definitely something to notify maintainers of >> ports (with kernel modules) about too. > > This change affects the KBI, as sysctl declarations now include an > additional pointer. The underlying sysctl registration function also > gained an additional argument. That said, if you simply rebuild all > kernel modules, this shouldn't cause any regressions, or are you > saying those persist? If so, this is definitely not an intended > side-effect of this change and we should look into it. Well, the kernel module doesn't compile anymore, of course: os.c:894:46: error: too few arguments to function call, expected 11, have 10 BALLOON_NAME_VERBOSE); ^ /usr/src/sys/sys/sysctl.h:1014:1: note: 'sysctl_add_oid' declared here struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, ^ 1 error generated. I am unsure why the VMware modules don't use the SYSCTL_XXX macros. Maybe these were not available in the past? Only the original maintainers might know. In any case, I have submitted a PR with a build fix, making use of the unrelated __FreeBSD_version bump, to add an additional NULL parameter to the call: https://bugs.freebsd.org/215353 -Dimitry --Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhVTNkACgkQsF6jCi4glqOP2QCgi4FhFa03ptYcFMeW1I1K3/8E VdQAnikv8uUUPIHH4u0vm6DB9fHb9Qa5 =NmzV -----END PGP SIGNATURE----- --Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A--