From owner-freebsd-bugs  Mon Jul  7 03:20:12 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id DAA06696
          for bugs-outgoing; Mon, 7 Jul 1997 03:20:12 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id DAA06688;
          Mon, 7 Jul 1997 03:20:04 -0700 (PDT)
Resent-Date: Mon, 7 Jul 1997 03:20:04 -0700 (PDT)
Resent-Message-Id: <199707071020.DAA06688@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG,
        David Nugent <davidn@labs.usn.blaze.net.au>
Received: from labs.usn.blaze.net.au (labs.usn.blaze.net.au [203.17.53.30])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA06586
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 7 Jul 1997 03:16:04 -0700 (PDT)
Received: (from davidn@localhost)
	by labs.usn.blaze.net.au (8.8.5/8.8.5) id UAA19462;
	Mon, 7 Jul 1997 20:15:53 +1000 (EST)
Message-Id: <199707071015.UAA19462@labs.usn.blaze.net.au>
Date: Mon, 7 Jul 1997 20:15:53 +1000 (EST)
From: David Nugent <davidn@labs.usn.blaze.net.au>
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/4046: use of srandomdev() in src/eBones/lib/libkrb/des_rw.c
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         4046
>Category:       bin
>Synopsis:       srandomdev() in stdlib.h now returns void, but return value used
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul  7 03:20:01 PDT 1997
>Last-Modified:
>Originator:     davidn@blaze.net.au
>Organization:
Unique Computing, Melbourne, Australia
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:

	3.0 current, after revision 1.9 of stdlib.h.
	Build eBones distribution.

>Description:

	return type of srandomdev() changed from int to void, but the
	return value was being used in src/eBones/lib/libkrb/des_rw.c.

>How-To-Repeat:

	Make world, include eBones.

>Fix:

--- des_rw.c.orig	Mon Jul  7 20:12:08 1997
+++ des_rw.c	Mon Jul  7 20:15:14 1997
@@ -230,8 +230,7 @@
 		 */
 		if(!seeded) {
 			seeded = 1;
-			if (srandomdev() < 0)
-				srandom((unsigned long)(time(NULL) ^ getpid()));
+			srandomdev();
 		}
 
 		for(i = 0 ; i < 8 ; i+= sizeof(long)) {


>Audit-Trail:
>Unformatted: