From owner-svn-src-all@freebsd.org Wed Mar 8 00:39:26 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F0D1D02DE8; Wed, 8 Mar 2017 00:39:26 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x22e.google.com (mail-pg0-x22e.google.com [IPv6:2607:f8b0:400e:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1493112C4; Wed, 8 Mar 2017 00:39:26 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x22e.google.com with SMTP id 25so6504379pgy.0; Tue, 07 Mar 2017 16:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9PyOHJYUmDTbzmSCDoJRbRhpwtQaj4zW6JCTIBaX8Zk=; b=ndP0N/26IQrHGKRX21SPU+8wOOg9fpYgy6Hv12Rp9qzeAHwIJ87Q5DveCrxFO02S1j wOMWJBTJ4z6Tdl6AKYiR2PUd5LouT6ZDlBbj3x+khfpAg/zW7DvgW2vY0fNHAJWhmvQ9 FuiSLFQ0Pt5AUKZWw0aC2US8BY1EjcTNM4P4PXeg9Dc8Uoq7Mt4JcFBr8ZjgVMNy/Cq2 wtLi3VWnCc/+HjSOIPr9GGUTm9hrmFG7+XVpbZ/gFNn78eIHrmImOB0hfVwJ9Gl0dba0 FQDYXqwBtY7TnuLeWjxi4xRWDG16EEqh6H+tiPIQXho4zSrHKRInpDrD7MrQSJY+sVdF pqwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9PyOHJYUmDTbzmSCDoJRbRhpwtQaj4zW6JCTIBaX8Zk=; b=GnO2WkejmlzkpuGAVfnPz98S57Yi4ke9qClVDxhDvgiRPTH+Z3T8Xh2YmYlRyt+Ccj wlpAaA0J3fl9C7FAHTEg63aceKKI1dCppAeF2vOeblhP6/sHGvpZla8NjbSihBg5npOM si9GoNjrE24u1rsBtc8cYrkIPT3aBHdMZ0lmcmXc84q5QwKG3Dzg5vn8ui3tZwPxSuti 7pL1udZeZzv6M+uddVRBMeyjY1SujCHqS3W1k3nO4ajbc3EjeEXkyaKnCYbGKi7E6IxI O78ZkySoeR+vtl/EMUCg4Pi93du1On9FzeInRYRsbOH6TSS66lJgpalf6z730FlBTDDS 1tZg== X-Gm-Message-State: AMke39lReUqOttzfonX1bppnn78dtVOL38uApC7MFbvjjNKIRukSbgDcBX9RS2DmrU1ahQ== X-Received: by 10.84.229.151 with SMTP id c23mr4436147plk.27.1488933565359; Tue, 07 Mar 2017 16:39:25 -0800 (PST) Received: from ?IPv6:2607:fb90:2774:28a:1009:464:f106:5ed6? ([2607:fb90:2774:28a:1009:464:f106:5ed6]) by smtp.gmail.com with ESMTPSA id x15sm1912185pgo.56.2017.03.07.16.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 16:39:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r314886 - in head: bin/pwait bin/pwait/tests etc/mtree targets/pseudo/tests From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: <201703072216.v27MGuEq086764@repo.freebsd.org> Date: Tue, 7 Mar 2017 16:39:23 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5FFD1DE3-3BB8-484F-9EFF-E8D5084322D9@gmail.com> References: <201703072216.v27MGuEq086764@repo.freebsd.org> To: Bryan Drewery X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 00:39:26 -0000 > On Mar 7, 2017, at 14:16, Bryan Drewery wrote: >=20 > Author: bdrewery > Date: Tue Mar 7 22:16:55 2017 > New Revision: 314886 > URL: https://svnweb.freebsd.org/changeset/base/314886 >=20 > Log: > pwait: Add a -t flag to specify a timeout before exiting, and tests. Thank you very much for writing tests! One general comment: it's not clear outside the commit message why the exit c= ode returned is 124. It might be a good idea to mention that in the code. > Added: head/bin/pwait/tests/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/bin/pwait/tests/Makefile Tue Mar 7 22:16:55 2017 (r314886)= > @@ -0,0 +1,5 @@ > +# $FreeBSD$ > + > +ATF_TESTS_SH=3D pwait The convention for the FreeBSD test suite is foo_test. Could you please rena= me this to pwait_test? > +atf_test_case basic > +basic_head() > +{ > + atf_set "descr" "Basic tests on pwait(1) utility" > +} > + > +basic_body() > +{ > + sleep 1 & > + p1=3D$! > + > + sleep 5 & > + p5=3D$! > + > + sleep 10 & > + p10=3D$! > + > + atf_check \ > + -o empty \ > + -e empty \ > + -s exit:0 \ > + -x timeout --preserve-status 15 pwait $p1 $p5 $p10 This should work without -x. > + atf_check \ > + -o empty \ > + -e inline:"kill: $p1: No such process\n" \ > + -s exit:1 \ > + -x kill -0 $p1 -x is only really needed if you need to invoke the snippet with /bin/sh in o= rder to use sh idioms, iirc. Thanks so much :)!!! -Ngie=