Date: Sat, 2 Mar 2013 16:54:54 GMT From: Glen Barber <gjb@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/176604: [patch] multimedia/mplayer2: DVDREAD option is not optional Message-ID: <201303021654.r22GssMQ005679@red.freebsd.org> Resent-Message-ID: <201303021700.r22H03jv058335@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 176604
>Category: ports
>Synopsis: [patch] multimedia/mplayer2: DVDREAD option is not optional
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 02 17:00:03 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Glen Barber
>Release: 10.0-CURRENT r247546
>Organization:
>Environment:
FreeBSD nucleus 10.0-CURRENT FreeBSD 10.0-CURRENT #87 r247546: Fri Mar 1 13:15:42 EST 2013 root@nucleus:/usr/obj/usr/src/sys/NUCLEUS amd64
>Description:
multimedia/mplayer2 OPTIONS lists DVDREAD as optional, however building without DVDREAD option leads to compile failure.
>How-To-Repeat:
Script started on Sat Mar 2 11:48:32 2013
root@nucleus:/usr/ports/multimedia/mplayer2 # make
===> Building for mplayer2-2.0.20130126
./version.sh
cc -o mplayer command.o m_property.o mixer.o mp_fifo.o mplayer.o parser-mpcmd.o screenshot.o input/input.o libao2/ao_null.o libao2/ao_pcm.o libao2/audio_out.o libvo/aspect.o libvo/csputils.o lib
vo/filter_kernels.o libvo/geometry.o libvo/old_vo_wrapper.o libvo/video_out.o libvo/vo_null.o libvo/vo_png.o libvo/vo_jpeg.o libvo/vo_md5sum.o libao2/ao_oss.o libvo/vo_pnm.o libvo/vo_tga.o libvo
/vo_yuv4mpeg.o asxparser.o av_log.o av_opts.o bstr.o codec-cfg.o cpudetect.o defaultopts.o fmt-conversion.o m_config.o m_option.o m_struct.o mp_msg.o mpcommon.o parser-cfg.o path.o playtree.o pl
aytreeparser.o subopt-helper.o talloc.o libaf/af.o libaf/af_center.o libaf/af_channels.o libaf/af_comp.o libaf/af_delay.o libaf/af_dummy.o libaf/af_equalizer.o libaf/af_extrastereo.o libaf/af_fo
rmat.o libaf/af_gate.o libaf/af_hrtf.o libaf/af_karaoke.o libaf/af_lavcac3enc.o libaf/af_lavcresample.o libaf/af_pan.o libaf/af_resample.o libaf/af_scaletempo.o libaf/af_sinesuppress.o libaf/af_
stats.o libaf/af_sub.o libaf/af_surround.o libaf/af_sweep.o libaf/af_tools.o libaf/af_volnorm.o libaf/af_volume.o libaf/filter.o libaf/format.o libaf/reorder_ch.o libaf/window.o libmpcodecs/ad.o
libmpcodecs/ad_alaw.o libmpcodecs/ad_dk3adpcm.o libmpcodecs/ad_dvdpcm.o libmpcodecs/ad_ffmpeg.o libmpcodecs/ad_hwac3.o libmpcodecs/ad_hwmpa.o libmpcodecs/ad_imaadpcm.o libmpcodecs/ad_msadpcm.o
libmpcodecs/ad_pcm.o libmpcodecs/dec_audio.o libmpcodecs/dec_teletext.o libmpcodecs/dec_video.o libmpcodecs/img_format.o libmpcodecs/mp_image.o libmpcodecs/pullup.o libmpcodecs/vd.o libmpcodecs/
vd_ffmpeg.o libmpcodecs/vd_hmblck.o libmpcodecs/vd_lzo.o libmpcodecs/vd_mpegpes.o libmpcodecs/vd_mtga.o libmpcodecs/vd_null.o libmpcodecs/vd_raw.o libmpcodecs/vd_sgi.o libmpcodecs/vf.o libmpcode
cs/vf_1bpp.o libmpcodecs/vf_2xsai.o libmpcodecs/vf_blackframe.o libmpcodecs/vf_boxblur.o libmpcodecs/vf_crop.o libmpcodecs/vf_cropdetect.o libmpcodecs/vf_decimate.o libmpcodecs/vf_delogo.o libmp
codecs/vf_denoise3d.o libmpcodecs/vf_detc.o libmpcodecs/vf_dint.o libmpcodecs/vf_divtc.o libmpcodecs/vf_down3dright.o libmpcodecs/vf_dsize.o libmpcodecs/vf_dvbscale.o libmpcodecs/vf_eq.o libmpco
decs/vf_eq2.o libmpcodecs/vf_expand.o libmpcodecs/vf_field.o libmpcodecs/vf_fil.o libmpcodecs/vf_filmdint.o libmpcodecs/vf_fixpts.o libmpcodecs/vf_flip.o libmpcodecs/vf_format.o libmpcodecs/vf_f
ramestep.o libmpcodecs/vf_fspp.o libmpcodecs/vf_geq.o libmpcodecs/vf_gradfun.o libmpcodecs/vf_halfpack.o libmpcodecs/vf_harddup.o libmpcodecs/vf_hqdn3d.o libmpcodecs/vf_hue.o libmpcodecs/vf_il.o
libmpcodecs/vf_ilpack.o libmpcodecs/vf_ivtc.o libmpcodecs/vf_kerndeint.o libmpcodecs/vf_lavc.o libmpcodecs/vf_lavcdeint.o libmpcodecs/vf_mirror.o libmpcodecs/vf_noformat.o libmpcodecs/vf_noise.
o libmpcodecs/vf_ow.o libmpcodecs/vf_palette.o libmpcodecs/vf_perspective.o libmpcodecs/vf_phase.o libmpcodecs/vf_pp7.o libmpcodecs/vf_pullup.o libmpcodecs/vf_qp.o libmpcodecs/vf_rectangle.o lib
mpcodecs/vf_remove_logo.o libmpcodecs/vf_rgbtest.o libmpcodecs/vf_rotate.o libmpcodecs/vf_sab.o libmpcodecs/vf_scale.o libmpcodecs/vf_screenshot.o libmpcodecs/vf_smartblur.o libmpcodecs/vf_softp
ulldown.o libmpcodecs/vf_stereo3d.o libmpcodecs/vf_softskip.o libmpcodecs/vf_swapuv.o libmpcodecs/vf_telecine.o libmpcodecs/vf_test.o libmpcodecs/vf_tfields.o libmpcodecs/vf_tile.o libmpcodecs/v
f_tinterlace.o libmpcodecs/vf_unsharp.o libmpcodecs/vf_uspp.o libmpcodecs/vf_vo.o libmpcodecs/vf_yadif.o libmpcodecs/vf_yuvcsp.o libmpcodecs/vf_yvu9.o libmpdemux/aac_hdr.o libmpdemux/asfheader.o
libmpdemux/aviheader.o libmpdemux/aviprint.o libmpdemux/demuxer.o libmpdemux/demux_aac.o libmpdemux/demux_asf.o libmpdemux/demux_audio.o libmpdemux/demux_avi.o libmpdemux/demux_demuxers.o libmp
demux/demux_edl.o libmpdemux/demux_film.o libmpdemux/demux_fli.o libmpdemux/demux_lavf.o libmpdemux/demux_lmlm4.o libmpdemux/demux_mf.o libmpdemux/demux_mkv.o libmpdemux/demux_mov.o libmpdemux/d
emux_mpg.o libmpdemux/demux_nsv.o libmpdemux/demux_pva.o libmpdemux/demux_rawaudio.o libmpdemux/demux_rawvideo.o libmpdemux/demux_realaud.o libmpdemux/demux_real.o libmpdemux/demux_roq.o libmpdemux/demux_smjpeg.o libmpdemux/demux_ts.o libmpdemux/demux_ty.o libmpdemux/demux_viv.o libmpdemux/demux_vqf.o libmpdemux/demux_y4m.o libmpdemux/ebml.o libmpdemux/extension.o libmpdemux/mf.o libmpdemux/mp3_hdr.o libmpdemux/mp_taglists.o libmpdemux/mpeg_hdr.o libmpdemux/mpeg_packetizer.o libmpdemux/parse_es.o libmpdemux/parse_mp4.o libmpdemux/video.o libmpdemux/yuv4mpeg.o libmpdemux/yuv4mpeg_ratio.o libvo/osd.o libvo/bitmap_packer.o osdep/numcores.o osdep/io.o osdep/getch2.o osdep/timer-linux.o stream/stream.o stream/stream_cue.o stream/stream_ffmpeg.o stream/stream_file.o stream/stream_mf.o stream/stream_null.o stream/url.o sub/dec_sub.o sub/find_sub.o sub/find_subfiles.o sub/sd_lavc.o sub/spudec.o sub/sub.o sub/sub_cc.o sub/subassconvert.o sub/subreader.o sub/vobsub.o timeline/tl_edl.o timeline
/tl_matroska.o stream/dvb_tune.o stream/stream_dvb.o stream/stream_dvdnav.o libvo/aclib.o stream/stream_ftp.o libmpcodecs/vf_bmovl.o libaf/af_export.o osdep/mmap_anon.o libmpcodecs/vd_ijpg.o osdep/shmem.o stream/asf_mmst_streaming.o stream/asf_streaming.o stream/cookies.o stream/http.o stream/network.o stream/pnm.o stream/rtp.o stream/udp.o stream/tcp.o stream/stream_rtp.o stream/stream_udp.o libmpcodecs/vd_mpng.o stream/cache2.o stream/stream_tv.o stream/tv.o stream/frequencies.o stream/tvi_dummy.o stream/tvi_bsdbt848.o sub/unrar_exec.o stream/stream_vcd.o libmpcodecs/ad_libvorbis.o libmpdemux/demux_ogg.o libmpcodecs/vd_xanim.o sub/osd_dummy.o -Wl,-z,noexecstack -L/usr/local/lib/ffmpeg1 -L/usr/local/lib/portaudio2 -L/usr/local/lib -ffast-math /usr/lib/libncurses.so -lpng -lz -ljpeg -lz -lvorbis -logg -L/usr/local/lib -llcms2 -lavutil1 -lavcodec1 -lavformat1 -L/usr/local/lib/ffmpeg1 -lswscale1 -pthread -rdynamic -L/usr/local/lib -ldvdnavmini -pthread -lm -lXss
stream/stream_dvdnav.o: In function `show_audio_subs_languages':
stream_dvdnav.c:(.text+0x71c): undefined reference to `dvd_audio_stream_channels'
stream_dvdnav.c:(.text+0x72f): undefined reference to `dvd_audio_stream_types'
stream/stream_dvdnav.o: In function `open_s':
stream_dvdnav.c:(.text+0x950): undefined reference to `dvd_speed'
stream_dvdnav.c:(.text+0x958): undefined reference to `dvd_set_speed'
stream_dvdnav.c:(.text+0xae1): undefined reference to `dvd_angle'
stream/stream_dvdnav.o: In function `stream_dvdnav_close':
stream_dvdnav.c:(.text+0xca1): undefined reference to `dvd_set_speed'
stream/stream_dvdnav.o: In function `fill_buffer':
stream_dvdnav.c:(.text+0x1524): undefined reference to `mp_dvdtimetomsec'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_VTS_ATRT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDCloseFile'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDOpen'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_VOBU_ADMAP'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_PGCI_UT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoOpen'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDReadBlocks'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoClose'
/usr/local/lib/libdvdnavmini.so: undefined reference to `navRead_DSI'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_FP_PGC'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_TITLE_VOBU_ADMAP'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_PTL_MAIT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoOpenVMGI'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_VTS_PTT_SRPT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoOpenVTSI'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_PGCIT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_TT_SRPT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `navRead_PCI'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDClose'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDOpenFile'
gmake: *** [mplayer] Error 1
*** [do-build] Error code 1
Stop in /usr/ports/multimedia/mplayer2.
*** [build] Error code 1
Stop in /usr/ports/multimedia/mplayer2.
root@nucleus:/usr/ports/multimedia/mplayer2 # ^D
Script done on Sat Mar 2 11:48:38 2013
>Fix:
Attached patch resolves it for me.
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 313277)
+++ Makefile (working copy)
@@ -49,18 +49,17 @@
MAKE_JOBS_SAFE= yes
OPTIONS_DEFINE= DEBUG RTC IPV6 SMB JOYSTICK \
- DVDREAD LIBBLURAY V4L DV THEORA \
+ LIBBLURAY V4L DV THEORA \
X11 XINERAMA OPENGL SDL VDPAU GIF CACA \
MAD SPEEX LIBCDIO LADSPA REALPLAYER \
JACK PULSE PORTAUDIO ASS LIRC
-OPTIONS_DEFAULT=DVDREAD X11 ASS
+OPTIONS_DEFAULT=X11 ASS
.if !defined(PACKAGE_BUILDING)
OPTIONS_DEFINE+= WIN32
OPTIONS_DEFAULT+= WIN32
.endif
-DVDREAD_DESC= Enable dvdread support
RTC_DESC= Enable kernel realtime clock timing
PULSE_DESC= Enable PulseAudio support
THEORA_DESC= Enable ogg theora video support
@@ -166,13 +165,6 @@
CONFIGURE_ARGS+= --disable-bluray
.endif
-.if ${PORT_OPTIONS:MDVDREAD}
-LIB_DEPENDS+= dvdread:${PORTSDIR}/multimedia/libdvdread
-CONFIGURE_ARGS+= --enable-dvdread
-.else
-CONFIGURE_ARGS+= --disable-dvdread
-.endif
-
.if ${PORT_OPTIONS:MSMB}
LIB_DEPENDS+= smbclient:${PORTSDIR}/net/samba-libsmbclient
.else
@@ -191,6 +183,9 @@
CONFIGURE_ARGS+= --disable-ladspa
.endif
+LIB_DEPENDS+= dvdread:${PORTSDIR}/multimedia/libdvdread
+CONFIGURE_ARGS+= --enable-dvdread
+
.if ${ARCH} == "i386" || ${ARCH} == "amd64"
.if ${PORT_OPTIONS:MWIN32} && !defined(PACKAGE_BUILDING) && ${ARCH} == "i386"
CODEC_PORT= ${PORTSDIR}/multimedia/win32-codecs
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303021654.r22GssMQ005679>