From owner-cvs-ports@FreeBSD.ORG Mon Sep 6 19:41:37 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE2B31065679 for ; Mon, 6 Sep 2010 19:41:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 830958FC1B for ; Mon, 6 Sep 2010 19:41:37 +0000 (UTC) Received: (qmail 21045 invoked by uid 399); 6 Sep 2010 19:41:36 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 6 Sep 2010 19:41:36 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C8543EF.1010205@FreeBSD.org> Date: Mon, 06 Sep 2010 12:41:35 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: Gerald Pfeifer References: <201009061123.o86BNY5u061220@repoman.freebsd.org> <4C85284D.8000707@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.1.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/emulators/wine Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2010 19:41:38 -0000 On 09/06/2010 11:28 AM, Gerald Pfeifer wrote: > On Mon, 6 Sep 2010, Doug Barton wrote: >>> Log: >>> Explicitly configure using --without-xcomposite, --without-xinerama and >>> --without-xrandr so that builds are more reproduciable and we avoi hidden >>> dependencies when building outside of a minimal build environment, thus >>> making packages more portable. >> That sounds very reasonable. I'm just wondering if you could add OPTIONS >> to enable those features however ... > > The short answer is: yes, based on concrete user feedback I have added > and will continue to add OPTIONS. Excellent. :) > The longer answers is: Wine itself has 44 --enable/--disable knobs and I > guess we do not want to have that many OPTIONS nor do we want to build it > with the maximum number of features and thus dependencies. What I am > trying to do is to have those features that are relevant for most users > always built, those where I see little to no use always disabled, and > those in between as OPTIONS. As I receive input and suggestions from > users, I move things between those three categories, the most common, > but not sole, move being the one from the disabled to the OPTIONS bucket. > > Does that sound like a reasonable approach? Yes of course, and I certainly agree that we don't want 44 knobs for one port. I would suggest that you consider grouping multiple related configure --options into one OPTIONS knob, but you've probably already considered that. :) hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso