Date: Sun, 2 Sep 2012 17:45:33 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Alberto Villa <avilla@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303465 - head/multimedia/mlt Message-ID: <20120902174533.GE10884@FreeBSD.org> In-Reply-To: <201209010946.q819kRxc085704@svn.freebsd.org> References: <201209010946.q819kRxc085704@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 01, 2012 at 09:46:27AM +0000, Alberto Villa wrote:
> -LICENSE= LGPL21 GPLv2 GPLv3
> +LICENSE= GPLv2 GPLv3 LGPL21
> LICENSE_COMB= multi
> -LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING
> LICENSE_FILE_GPLv2= ${WRKSRC}/GPL
> LICENSE_FILE_GPLv3= ${WRKSRC}/GPLv3
> +LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING
Any special reason to install copies of standard licenses?
> +GTK2_DESC= GTK+ 2 support (images, text rendering...)
It seems that we commonly do not put space after GTK+ (e.g. GTK+1, GTK+2).
> +LIB_DEPENDS+= avformat:${PORTSDIR}/multimedia/ffmpeg
> CONFIGURE_ARGS+= --enable-avformat \
> --avformat-swscale
You could have saved a line in CONFIGURE_ARGS here since both options would
fit on one line. \ makes sense for long argument list to improve
readability and "svn blame" output, but not in this particular case.
> -.ifndef(WITHOUT_GTK2)
> +.if ${PORT_OPTIONS:MGTK2}
> LIB_DEPENDS+= exif.12:${PORTSDIR}/graphics/libexif
You also could've dropped shlib version number here (and below), unless
particular ABI is indeed required (in this case, it should been mentioned
in commit log or Makefile comment).
> pre-configure:
> - ${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
> + ${REINPLACE_CMD} -e 's,/usr/local,${LOCALBASE},g' \
These seem unnecessary and just shadow whom to "svn blame". Also, perhaps
global modifier is superfluous here (also below).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120902174533.GE10884>