From owner-svn-src-all@freebsd.org Thu May 26 22:00:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 042DDB4C906; Thu, 26 May 2016 22:00:03 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 7EFD313AC; Thu, 26 May 2016 22:00:02 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r300771 - head/sys/netgraph/netflow To: Gleb Smirnoff References: <201605261857.u4QIvQpN074167@repo.freebsd.org> <20160526214544.GL58287@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Jung-uk Kim Message-ID: Date: Thu, 26 May 2016 17:59:55 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160526214544.GL58287@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FqaTNpHGIEQMIOqB4EEjcXKDDGfHLmxv1" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 22:00:03 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FqaTNpHGIEQMIOqB4EEjcXKDDGfHLmxv1 Content-Type: multipart/mixed; boundary="pk8geoWrOJ06QXrQL2SsXPliUtjKRfMMn" From: Jung-uk Kim To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r300771 - head/sys/netgraph/netflow References: <201605261857.u4QIvQpN074167@repo.freebsd.org> <20160526214544.GL58287@FreeBSD.org> In-Reply-To: <20160526214544.GL58287@FreeBSD.org> --pk8geoWrOJ06QXrQL2SsXPliUtjKRfMMn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 05/26/16 05:45 PM, Gleb Smirnoff wrote: > On Thu, May 26, 2016 at 06:57:26PM +0000, Jung-uk Kim wrote: > J> Author: jkim > J> Date: Thu May 26 18:57:26 2016 > J> New Revision: 300771 > J> URL: https://svnweb.freebsd.org/changeset/base/300771 > J>=20 > J> Log: > J> Use bit_count(3) instead of four bitcount32() calls. > J> =20 > J> Reviewed by: asomers, ngie > J> Differential Revision: https://reviews.freebsd.org/D6543 >=20 > The bitcount32() is still used for IPv4 addresses. Is that intentional?= Yes. bit_count(3) is only useful when data is bigger than long. Jung-uk Kim --pk8geoWrOJ06QXrQL2SsXPliUtjKRfMMn-- --FqaTNpHGIEQMIOqB4EEjcXKDDGfHLmxv1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXR3HcAAoJEHyflib82/FGfXAH/1AwKoYcpl1zpACvv99tpErm itVYi1Se8ggU2Di83nADuDVnFdycZyq1X+kQZCbxeYFqc2mH2oggYUIJXRom6yDP DiL1V7yHyQIwxtcGx3B9kBWTdFOsbub9zXmGoFC+llkTk9eIzWDAw7wmwlS+KwdE clB7bLyYcxoyKBn46BgslObbVKsWnfNIyRAqFB6Z/4obrYMDorT506acoxnG5jeU 5EFss90m4ZqUgCrOgy9DkEp5+eOfOkq1rTB24FXo1WYMOGheQQagZmKg2KuAWm7c QPaZ2SxCLvk2L27tOQRSJD1Q2m2I+545SSmn+9sux/5lCJHOZowJd/PgbO9FnRQ= =EltX -----END PGP SIGNATURE----- --FqaTNpHGIEQMIOqB4EEjcXKDDGfHLmxv1--