Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Aug 1995 13:26:28 -0400
From:      "Garrett A. Wollman" <wollman@lcs.mit.edu>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        CVS-commiters@freefall.FreeBSD.org, bde@freefall.FreeBSD.org, cvs-sys@freefall.FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm vm_map.h vm_map.c
Message-ID:  <9508271726.AA27912@halloran-eldar.lcs.mit.edu>
In-Reply-To: <199508270107.LAA23799@godzilla.zeta.org.au>
References:  <199508270107.LAA23799@godzilla.zeta.org.au>

next in thread | previous in thread | raw e-mail | index | archive | help
<<On Sun, 27 Aug 1995 11:07:50 +1000, Bruce Evans <bde@zeta.org.au> said:

> 1) for syscalls.  The conversion from the application's args is
[...]
>       bar_args *'.  Perhaps the right method is to pass a `void *'
>       or `int *' and convert it in each function, like you have to
>       do for qsort().

This is precisely the approach I took when doing this rationalization
in 1.x.  I would have preferred to continue it (and fix the current
syscalls to match the old model), but other people wanted to do it the
new (broken) 4.4-Lite way, and I let them have their way.

> 2) for protoswitch functions.  The number and type of args sometimes
>    depends on the protocol.

For pr_input routines, it always depends on the protocol.  The
solution that I prefer for these is to declare pr_input as a `void
(*)(void)' and then define some protocol-specific macros to cast it to
the correct value.  If there were a way I could think of to use unions
the same way for increased type-safety, I'd prefer that.

> If everything passed the correct number and type of args then we
> could compile the kernel with -mrtd -mregparm to save a few cycles.
> -mregparm is officially supported for the i386 in gcc-2.7.0.

This would be a nice thing to have.  There are almost certainly other
architectures where it would benefit more.

-GAWollman

--
Garrett A. Wollman   | Shashish is simple, it's discreet, it's brief. ... 
wollman@lcs.mit.edu  | Shashish is the bonding of hearts in spite of distance.
Opinions not those of| It is a bond more powerful than absence.  We like people
MIT, LCS, ANA, or NSA| who like Shashish.  - Claude McKenzie + Florent Vollant



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9508271726.AA27912>