Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Sep 2020 04:28:32 +0000 (UTC)
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r547322 - head/audio/aqualung
Message-ID:  <202009020428.0824SWxG092406@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: danfe
Date: Wed Sep  2 04:28:31 2020
New Revision: 547322
URL: https://svnweb.freebsd.org/changeset/ports/547322

Log:
  Remove unused duplicate global symbols to fix the build against modern
  compilers which by default place uninitialized global variables in the
  BSS section of the object file; this inhibits the merging of tentative
  definitions by the linker and results in the multiple-definition error
  because the same variable is defined in more than one compilation unit.
  
  Reported by:	pkg-fallout

Modified:
  head/audio/aqualung/Makefile

Modified: head/audio/aqualung/Makefile
==============================================================================
--- head/audio/aqualung/Makefile	Wed Sep  2 04:28:03 2020	(r547321)
+++ head/audio/aqualung/Makefile	Wed Sep  2 04:28:31 2020	(r547322)
@@ -53,4 +53,10 @@ SNDIO_LIB_DEPENDS=	libsndio.so:audio/sndio
 SNDIO_CONFIGURE_ON=	--with-sndio=yes
 SNDIO_CONFIGURE_OFF=	--with-sndio=no
 
+post-patch:
+# Remove unused duplicate global symbols (-fno-common)
+	@${REINPLACE_CMD} -E '/^g?char command/d' \
+		${WRKSRC}/src/gui_main.c \
+		${WRKSRC}/src/playlist.c
+
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202009020428.0824SWxG092406>