From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 3 11:10:32 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DEE9016A47E for ; Sun, 3 Dec 2006 11:10:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id A533243CA8 for ; Sun, 3 Dec 2006 11:09:44 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kB3BAAgI060707 for ; Sun, 3 Dec 2006 11:10:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kB3BAAwZ060706; Sun, 3 Dec 2006 11:10:10 GMT (envelope-from gnats) Resent-Date: Sun, 3 Dec 2006 11:10:10 GMT Resent-Message-Id: <200612031110.kB3BAAwZ060706@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rene Ladan Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0FB3E16A412 for ; Sun, 3 Dec 2006 11:04:46 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7A1F43C9D for ; Sun, 3 Dec 2006 11:04:19 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kB3B4jkh098475 for ; Sun, 3 Dec 2006 11:04:45 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id kB3B4jcS098474; Sun, 3 Dec 2006 11:04:45 GMT (envelope-from nobody) Message-Id: <200612031104.kB3B4jcS098474@www.freebsd.org> Date: Sun, 3 Dec 2006 11:04:45 GMT From: Rene Ladan To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: kern/106255: [msdosfs] : correct setting of archive flag X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2006 11:10:33 -0000 >Number: 106255 >Category: kern >Synopsis: [msdosfs] : correct setting of archive flag >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 03 11:10:10 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rene Ladan >Release: 7.0 CURRENT 2006-11-26 >Organization: >Environment: FreeBSD s000655.campus.tue.nl 7.0-CURRENT FreeBSD 7.0-CURRENT #21: Mon Nov 27 17:53:03 CET 2006 root@s000655.campus.tue.nl:/usr/obj/usr/src-current/sys/RENE i386 >Description: The MSDOS file system has an archive bit in the flags field. This bit roughly corresponds to the archive flag on the UFS file system. However, it is set the wrong way around: the flag should be set when the bit is present, and cleared when the bit is absent. >How-To-Repeat: 1. Mount an MSDOS file system with some files marked as archived, and some not. 2. List its files with 'ls -lo' The archive flag will turn up inversed. >Fix: Patch attached with submission follows: --- msdosfs_vnops.c Mon Nov 6 14:41:57 2006 +++ msdosfs_vnops.c.rene Sun Dec 3 11:58:47 2006 @@ -352,7 +352,7 @@ vap->va_ctime = vap->va_mtime; } vap->va_flags = 0; - if ((dep->de_Attributes & ATTR_ARCHIVE) == 0) + if (dep->de_Attributes & ATTR_ARCHIVE) vap->va_flags |= SF_ARCHIVED; vap->va_gen = 0; vap->va_blocksize = pmp->pm_bpcluster; >Release-Note: >Audit-Trail: >Unformatted: