From nobody Tue Aug 29 08:54:31 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RZh7X0LC0z4rY7b for ; Tue, 29 Aug 2023 08:54:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RZh7W6Nxkz4WRZ for ; Tue, 29 Aug 2023 08:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693299271; a=rsa-sha256; cv=none; b=fP8DO82bOooukwe1o5pEpZr7uM0ni0Ffm64NAx0C9Otwuwdyn2u2soM5nOzLe6NhUMgBLA VcDbxUTxMFq4VPaeamUWUThcGNvb5VSRqqFaV1c4FHK9IpgPBtpC+sDeMv1HNxjtMktPaO fzqtEom4R4aZM2YMsf9kc0yrtlb/DOAcBU9BwN6fUODkQD267sZCIlR8PnFPpTcMgjpvrn zu/FDytNulV87IETxcNGWmG1BqwHTOvH6nNAVZRyu3uAf2oCaJMB4qSRPCoLxY4quhUbnr zHPY7fyzE3b71ugk/ouYi0z64/v6V+jl8r6nXPijyTk2CQm5FH8y+YvuR1Zd8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693299271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bksnDVaxd/u2wdY1SXezVqvhmJetI3xJLkOoEZRVHps=; b=hQMTKCrY5RnTOEcjS2QH9otZJi3w0RIpezmFWR+h42SyDQVgVvUVr+Y35oNFoxFYABhC5T J0+sI7Qdh3F+jR78KuI0QtWF2euxQSGLxYqxBhbmdwB4BrYDp7dbOMMtumu+P4N8iLwybV WXRkjOOolmyePqqevTX4P8m9+iMqVpniEmRiYdAENoFbkHBpKRjZTnlR/JoieT0rwRoZXH Hrm9uyKLDYh0kkL0CPAvyes2sgRJO065jo7HX8UpQ9liwJNtiBprx03TlFUXVyeq7l5X8H s43z/91+M5MhiCRl5bCaviXXZH/d3MdwKuPRwVOOXXBT9Xbvrq1ZosPmia4F+w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RZh7W5MCgzlSj for ; Tue, 29 Aug 2023 08:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37T8sVBK076621 for ; Tue, 29 Aug 2023 08:54:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37T8sVXT076620 for bugs@FreeBSD.org; Tue, 29 Aug 2023 08:54:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273414] linuxulator regression in symlinks under zfs Date: Tue, 29 Aug 2023 08:54:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dchagin@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: dchagin@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273414 --- Comment #2 from Dmitry Chagin --- here it rather makes sense to speak about regression in vfs/namecache/ufs d= ue to the fact that: 1. starting from https://cgit.freebsd.org/src/commit/sys/kern/vfs_cache.c?id=3D739ecbcf1c4fd= 22b5f6ee0bb180a67644046a3e0 file systems should cache symbolic link targets on their own. This method is not implemented for UFS, so the described bug does not occur for UFS. 2. UFS currently does not use namecache at all, so this bug does not occur.= See here: https://reviews.freebsd.org/D41337, https://reviews.freebsd.org/D41338 I think it would be correct to modify the algorithm of the namei() and cache_fplookup() functions so that file systems are not responsible for cac= hing symlink targets, ie, cache_fplookup() should stop its loop and return PARTI= AL in case of a symbolic link, and namei() should resolve the symlink and go to the cache lookup starting from the current directory. As a temporary fix, try this patch, please: https://people.freebsd.org/~dchagin/vfs.patch --=20 You are receiving this mail because: You are on the CC list for the bug.=