From owner-freebsd-office@FreeBSD.ORG Mon Nov 5 06:50:41 2012 Return-Path: Delivered-To: office@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A6605748 for ; Mon, 5 Nov 2012 06:50:41 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6F6598FC08 for ; Mon, 5 Nov 2012 06:50:41 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id rp8so3890199pbb.13 for ; Sun, 04 Nov 2012 22:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:message-id:to:cc:subject:from:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; bh=sUGqsNg0AHytOqpcOdw7pg3SeYHGsk1F4RTbVjDXgdE=; b=fnPx9b6WdpvUBt19axjK1Jmt5Nnlw255iZ2v2bCX7pcKEaeMTRhESVOCnU4KwSMZ+K pTI2E73B7VBGJ2Lkzltm7hDJt3oxGSAhzfMBwQHdhxXaMnvel6Ju+6HfVN5zweuwbYRY Z0eIbbB7/ZUeS58hUuLyw2hPEjUFrlqA1fzJlnzaBQOJMWzysig5x4r/5f28wrJJiUPO SRHv/f63vvv1zVEYzL3jgpbYiN9zYg9rYP0ZRXiglnmdQmd+/QCYQRz0yfAs/S6bwGbR 6FYtNOoSHBRWcLhaqg0HAJBtAJ4MHrcNnFyMjb/dB5A6/zgnkj988BgxGLUKIoWdg9De Y1mg== Received: by 10.66.89.138 with SMTP id bo10mr26203286pab.0.1352098240908; Sun, 04 Nov 2012 22:50:40 -0800 (PST) Received: from localhost (rikad42.riken.jp. [134.160.214.42]) by mx.google.com with ESMTPS id g10sm10164095pav.9.2012.11.04.22.50.39 (version=SSLv3 cipher=OTHER); Sun, 04 Nov 2012 22:50:40 -0800 (PST) Sender: Maho NAKATA Date: Mon, 05 Nov 2012 15:50:38 +0900 (JST) Message-Id: <20121105.155038.872338780898971147.maho@FreeBSD.org> To: gerald@pfeifer.com Subject: Re: Eliminating use of _GCC_BUILD_DEPENDS from openoffice-3-devel From: Maho NAKATA In-Reply-To: References: X-Mailer: Mew version 6.3 on Emacs 24.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: office@FreeBSD.org X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2012 06:50:41 -0000 Hi Gerald Without that, building AOO fails at odk module like following: /usr/local/bin/bash: line 1: 90954 Abort trap: 6 (core dumped) LD_LIBRARY_PATH=/work/tinderbox-ligeti8amd64/portstrees/Fr\ eeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}} /work/tinde\ rbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc -html ../..\ /unxfbsdx.pro/bin/odkcommon/docs/common/ref -dvgroot "http://wiki.services.openoffice.org/wiki" -name "OpenOffice.org 3.4 API" -lg \ idl -dvgfile idl_chapter_refs.txt -t ../../unxfbsdx.pro/bin/odkcommon/idl dmake: Error code 134, while making '../../unxfbsdx.pro/bin/odkcommon/docs/common/ref/module-ix.html' > Is there any chance we can work on this together and identify why > you felt it was necessary in the first place? For, it should not, yes, sure. and necessity is described above. > and rather just work with the standards ports infrastructure. >> post-patch: >> .if defined (USE_GCC) >> - @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/inc/unxfbsd.mk >> - @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/inc/unxfbsd.mk >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk >> .else >> @${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/inc/unxfbsd.mk >> @${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk I tried both by cd /usr/ports/editors/openoffice-3-devel ; make USE_GCC=4.6 -> build was successful. commenting out >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/inc/unxfbsd.mk >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk then cd /usr/ports/editors/openoffice-3-devel ; make USE_GCC=4.6 -> build was broken at odk like following. /usr/local/bin/bash: line 1: 90954 Abort trap: 6 (core dumped) LD_LIBRARY_PATH=/work/tinderbox-ligeti8amd64/portstrees/Fr\ eeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}} /work/tinde\ rbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc -html ../..\ /unxfbsdx.pro/bin/odkcommon/docs/common/ref -dvgroot "http://wiki.services.openoffice.org/wiki" -name "OpenOffice.org 3.4 API" -lg \ idl -dvgfile idl_chapter_refs.txt -t ../../unxfbsdx.pro/bin/odkcommon/idl dmake: Error code 134, while making '../../unxfbsdx.pro/bin/odkcommon/docs/common/ref/module-ix.html' Thanks, Nakata Maho From: Gerald Pfeifer Subject: Re: Eliminating use of _GCC_BUILD_DEPENDS from openoffice-3-devel Date: Sat, 03 Nov 2012 17:25:42 +0100 (CET) > I now applied this based on maintainer timeout (3 weeks). > > Is there any chance we can work on this together and identify why > you felt it was necessary in the first place? For, it should not, > and rather just work with the standards ports infrastructure. > > Together I believe we'll be able to eradicate this hack altogether. > > Gerald > > On Sat, 13 Oct 2012, Gerald Pfeifer wrote: >> _GCC_BUILD_DEPENDS never was meant to be used outside of Mk/bsd.gcc.mk, >> and the settings of CFLAGS et al really should be sufficient. >> >> Apparently it was felt that was not the case, or something is not >> working as it should, I don't think I was asked about before this >> was put in. >> >> In any case, can we go for this patch which eliminates _GCC_BUILD_DEPENDS >> in favor of a new _GCC_RUNTIME? That is a stop gap, but at least >> an official one and easier than manually constructing the library >> path. >> >> Okay to apply the patch below to openoffice-3-devel and, a bit >> later, openoffice-3? >> >> Thanks, >> Gerald >> >> Index: Makefile >> =================================================================== >> --- Makefile (revision 305792) >> +++ Makefile (working copy) >> @@ -1,9 +1,5 @@ >> -# New ports collection makefile for: Apache OpenOffice >> -# Date created: 28 February 2002 >> -# Whom: Martin Blapp >> -# >> +# Created by: Martin Blapp >> # $FreeBSD$ >> -# >> >> PORTNAME= apache-openoffice >> PORTVERSION= 3.4.${SVNREVISION} >> @@ -252,8 +248,8 @@ >> >> post-patch: >> .if defined (USE_GCC) >> - @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/inc/unxfbsd.mk >> - @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/inc/unxfbsd.mk >> + @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk >> .else >> @${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/inc/unxfbsd.mk >> @${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk >> >