From owner-freebsd-hackers@freebsd.org Sun Dec 13 19:43:20 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7CD7C4C200D for ; Sun, 13 Dec 2020 19:43:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CvFLc2wZYz4pKG for ; Sun, 13 Dec 2020 19:43:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id i67so6255239qkf.11 for ; Sun, 13 Dec 2020 11:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Leym17MSasUK2v3VSsn3mdFaJKRsq3D9WOBNyFTzC3Q=; b=IVXUUYu5/f6KpWLS36lK+tbknQFdSG1IpiF/CALQTmhFyicurzlwfTGqTClYWhC5hC QR9MDZEGAUqg80qOh/v54m1u3rUPqfqZfg69Vgw7nx/D6WJtLO0/QnKHNWs3NZ/ihIPb IbzbYF7EBQKRYDGV/RS9TscztP80znZGzEFLMX9IpOGFeCKVvmb2Dw2vWSolc4CeiBiO R5S+3qFYxe78hd+F6lCYM9lurRWjXijWf72DCmEwzwE1tc6tyiRvfKwRSmHMr2PZC7ry ubel3OyOayEHVp3zjJR2RcA1bSwYRbgdrVu/SIEOleRA0nVQzkFQmIPli2oA0McoptQI D+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Leym17MSasUK2v3VSsn3mdFaJKRsq3D9WOBNyFTzC3Q=; b=SwKQQk/tTNOHCNK9CCDbyHmc2hG39j0El+DJ0OacjLYmay9mH0sibNEglwsOS4qfhv 85Nd2vW4OO6wEZfkywFx1jMTu9dRv4ACE87d7MJSF3ozb8VT+Cq/13XFCFV1sJ54Gsuq xGNW05DNoiyIQTXbFQgxMU+xrqJ9mMIpIGzgY2towhmTieQF9880n8LJxnUGEgKng4Ov b+fjNnwauKx7dyG1r1ALTg+6IKeZbwu8WcMvarMKA8A7keppxRy8zzVU2r5p6z+0dCh4 /ydYfnOn+PGSsatQoQ6iaEPAxxjnl6l1oU9nhjJ6F25x1R85jtkfZI8a7m4GHS+lF+RZ 00Kw== X-Gm-Message-State: AOAM530HdHp7j+yZdJqYMWtRRN5t3q1gQO4Ke6OQjK9oRdH62JUlX4yu /qtQR5zwsewPJy5pBFi+GTZABVZiVrFN15Cw6C2vdA== X-Google-Smtp-Source: ABdhPJx7KXaNEOqwGmVFH+Ekd/1vi2QX9Rsdw/RHL2e39slFYMTYsOmynMbbHBNJA4q1OQJY8okiVJ3QbFuvYBAawYQ= X-Received: by 2002:ae9:ebd5:: with SMTP id b204mr28913543qkg.195.1607888599139; Sun, 13 Dec 2020 11:43:19 -0800 (PST) MIME-Version: 1.0 References: <6dd927984d69ef0e95e1e90651bcd8087bc4eec4.camel@freebsd.org> In-Reply-To: From: Warner Losh Date: Sun, 13 Dec 2020 12:43:08 -0700 Message-ID: Subject: Re: char devices without SI_UNMAPPED? To: Konstantin Belousov Cc: Alan Somers , Ian Lepore , FreeBSD Hackers X-Rspamd-Queue-Id: 4CvFLc2wZYz4pKG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Dec 2020 19:43:20 -0000 On Sun, Dec 13, 2020 at 12:40 PM Konstantin Belousov wrote: > On Sun, Dec 13, 2020 at 12:20:49PM -0700, Alan Somers wrote: > > On Sun, Dec 13, 2020 at 11:20 AM Warner Losh wrote: > > > > > > > > > > > On Sun, Dec 13, 2020 at 11:18 AM Ian Lepore wrote: > > > > > >> On Sun, 2020-12-13 at 10:27 -0700, alan somers wrote: > > >> > I'm trying to exercise the aio code that handles character devices > > >> > that > > >> > don't set the SI_UNMAPPED flag. But I can't find any. Are there > any > > >> > remaining character devices that don't allow unmapped I/O? > > >> > > > >> > -Alan > > >> > > > >> > > >> I assume you mean disk-like devices? Probably mmcsd, flash/at45d, > > >> flash/mx25l. > > >> > > > > > Hm. I don't have any of those. > > > > > > > > > > There are times that it's disabled administratively as well, but that > may > > > be on a per-I/O basis. > > > vfs.zfs.vol.unmap_enabled: 1 > > > > > > > This one doesn't seem to work. It looks like the only functionality it > > gates these days is DIOCGDELETE. > > > > > > > vfs.unmapped_buf_allowed: 1 > > > > > > > Well, this one works. Thanks for the tip. Unfortunately, it's a > tunable, > > so I can't use it for any kind of automated testing. > > There is enough geoms which do not support unmapped bios, even if only in > some configurations. Recursively grep for G_PF_ACCEPT_UNMAPPED in sys/geom > to see what I mean. > > After all, an option for geom_nop should be trivial, to force all bios to > map, instead of inheriting from the lower provider. > There's also several CAM SIMs that don't set the PIM_UNMAPPED flag either: % grep -rl cam_sim_alloc . | wc 58 58 1378 % grep -lr PIM_UNMAPPED . | wc 28 28 658 Warner