From owner-freebsd-stable@FreeBSD.ORG Thu Jun 1 07:25:51 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55C7416A88F for ; Thu, 1 Jun 2006 07:25:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from fw.zoral.com.ua (ll-227.216.82.212.sovam.net.ua [212.82.216.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3607743D45 for ; Thu, 1 Jun 2006 07:25:49 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id k517PecH016321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Jun 2006 10:25:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.6/8.13.6) with ESMTP id k517PeGT049765; Thu, 1 Jun 2006 10:25:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.6/8.13.6/Submit) id k517PcC2049764; Thu, 1 Jun 2006 10:25:38 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 1 Jun 2006 10:25:38 +0300 From: Konstantin Belousov To: Dmitry Pryanishnikov Message-ID: <20060601072538.GZ54541@deviant.kiev.zoral.com.ua> References: <001401c67f56$b02975e0$071872cf@Leadmon.local> <003001c67fae$27a88370$071872cf@Leadmon.local> <20060525051926.GB97976@xor.obsecurity.org> <20060525145809.GP54541@deviant.kiev.zoral.com.ua> <20060530223342.G2710@atlantis.atlantis.dp.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gvPGo+RAdjC9O5ul" Content-Disposition: inline In-Reply-To: <20060530223342.G2710@atlantis.atlantis.dp.ua> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on fw.zoral.com.ua Cc: Howard Leadmon , 'Rong-en Fan' , freebsd-stable@freebsd.org, Kris Kennaway Subject: Re: [patch, try 1] Re: Trouble with NFSd under 6.1-Stable, any ideas? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:25:55 -0000 --gvPGo+RAdjC9O5ul Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2006 at 01:06:44AM +0300, Dmitry Pryanishnikov wrote: >=20 > Hello! >=20 > On Thu, 25 May 2006, Konstantin Belousov wrote: > > KASSERT(!(debug_mpsafenet =3D=3D 1 && mtx_owned(&Giant)), > > ("nfssvc_nfsd(): debug.mpsafenet=3D1 && Giant")); > > > >from nfsserver/nfs_syscalls.c, line 570. > > > >As I understand the problem, kern/vfs_lookup.c:lookup() could > >aquire additional locks on Giant, indicating this by GIANTHELD > >flag in nd. All processing in nfsserver already goes with Giant held, > >so, I just dropped that excessive locks after return from lookup. > >System with patch applied survived smoke test (client did > >du on mounted dir, patch was generated from exported fs, etc.). > >nfsd eats no more than 25% of CPU (with INVARIANTS). > > > >Please, users who reported the problem and willing to help, > >try the patch (generated against STABLE) and give the feedback. >=20 > Thank you very much. Your patch actually fixes "nfssvc_nfsd():=20 > debug.mpsafenet=3D1 && Giant" panic during NFS mount of server's "/usr". > Oddly enough, NFS mount of server's "/" doesn't panic the server. Because conditions leading to Giant leak usually hold true for lookup of ".." :) --gvPGo+RAdjC9O5ul Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfpZxC3+MBN1Mb4gRAmlCAKC7xgGsRqzi9uVZbGXUN2qjBbGBTQCgmKI3 mLEOIFTYO6qpb9fwSBo4XO4= =MzgR -----END PGP SIGNATURE----- --gvPGo+RAdjC9O5ul--