Date: Wed, 28 Mar 2018 22:01:23 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r465830 - head/astro/stellarium Message-ID: <20180328200123.qpzqw72heamkgqrg@atuin.in.mat.cc> In-Reply-To: <20180328185841.GA93245@FreeBSD.org> References: <201803281720.w2SHKmHU086890@repo.freebsd.org> <20180328172437.GA20977@FreeBSD.org> <20180328180646.aqml7rdmr773xiot@ogg.in.absolight.net> <20180328185841.GA93245@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--zewbh2jqrkuzcmnr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 28, 2018 at 06:58:41PM +0000, Alexey Dokuchaev wrote: > On Wed, Mar 28, 2018 at 08:06:46PM +0200, Mathieu Arnold wrote: > > On Wed, Mar 28, 2018 at 05:24:37PM +0000, Alexey Dokuchaev wrote: > > > On Wed, Mar 28, 2018 at 05:20:48PM +0000, Alexey Dokuchaev wrote: > > > > New Revision: 465830 > > > > URL: https://svnweb.freebsd.org/changeset/ports/465830 > > > >=20 > > > > Log: > > > > - Update `astro/stellarium' to version 0.18.0 > > > > - TIMESTAMP (Stellarium-stellarium-v0.17.0_GH0.tar.gz) =3D 152196= 7282 > > > ^^^^^^ > > > Ah, sorry, I've fucked up, it should read 0.18.0. TIMESTAMP logic sh= ould > > > really be fixed so we won't have to reiterate it in the commit logs. = :-( > >=20 > > It was decided that the TIMESTAMP logic would work as it currently does, > > so these lines you add to your commit messages are really not needed. >=20 > Current logic is both confusing and redundant, as it adds yet another > timestamp to already existing distfile(s) timestamp and commit timestamp. >=20 > Per my understanding, it was only put in place because of Git, which does > not support keyword expansion. Personally I don't understand why would we > want to support a crippled VCS, but before I figure a way out of this, I > feel that proper TIMESTAMP metainfo should either go to commit message, or > be recorded elsewhere. It needs to be VCS and filesystem independant, we do not want to rely on outside metadata. The timestamp needs to be stored in some file, the distinfo file was considered the best solution. --=20 Mathieu Arnold --zewbh2jqrkuzcmnr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJau/STXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I/uMP/2h2yMjLvLEszgdySQ/y6CLL sRqDrFeHgBaKDZJ8XYlUb248jZULU8Qvgycvj7CCtUtBCsrIxvRiTpediPSs9C47 xrq5qdG7mMBLO5IrK/O/l33JkbYcHuMPtjj4ux5aFghApvUnNeXJf45kRrA7J3Wh OxjeUfz4AuPdfCCICI0CHVsCkbKe6ooAUURwidQlh8rSGeM4bOk49HafJzb37HcF 1ZuBO3oLq8tRneoYmvzuLEp2gpbu9dRvHTQRpxO84I67mVk0Ye8BMkZmlRrQC6Kh ruTazguE3ltvhZ4SQXXlIfu7QhKTZx1s29QVBTPMTp7PHNOdQHtYq6dTuoOAdoeH PbcVJMJK0nGgHLb78/lzF2QQ8DM6ggblX3BxPnM1z8zX+0SrqBazWjow1DlcMYk9 tcca491yphtCQ1zWA8Jc/UKF30Xuk0YvESMiO9jlPf5WKdcZ2k2iEKuQfr0PNhQI U143svQiCswANUA1spMeVGjLZhq1cf2Mri7TKqh6r5mT/F0MK+GTy3f2Yosl7zvo zBBFbFPIXl5Y4POPVwYNRM1biqmphuLblggNoGg39Ux9jUFIXJo+DwyhYp0YZyoZ vYrKU0ROHygwFSACsc5bItMqaoBqSf2l5ctnJ8wzQS2v3n5BolQVFD6UvF/kpsdI 0tSlti4nBe4vUMR5Ogki =wrdN -----END PGP SIGNATURE----- --zewbh2jqrkuzcmnr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180328200123.qpzqw72heamkgqrg>