From owner-svn-ports-all@FreeBSD.ORG Sun Mar 29 16:44:45 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D228D7C3; Sun, 29 Mar 2015 16:44:45 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 949B19D4; Sun, 29 Mar 2015 16:44:45 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id D3944BDC2E; Sun, 29 Mar 2015 18:44:43 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id BE37EBDC24; Sun, 29 Mar 2015 18:44:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 8CBF52E4E23D; Sun, 29 Mar 2015 18:44:43 +0200 (CEST) Date: Sun, 29 Mar 2015 18:44:43 +0100 From: Mathieu Arnold To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r382595 - head/net/hostapd Message-ID: <95DE044D7600DE3AD898D6A6@atuin.in.mat.cc> In-Reply-To: <5517F013.6090403@marino.st> References: <201503291215.t2TCFfpV085298@svn.freebsd.org> <5517F013.6090403@marino.st> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2015 16:44:45 -0000 +--On 29 mars 2015 14:29:07 +0200 John Marino wrote: | On 3/29/2015 15:20, Mathieu Arnold wrote: |> +--On 29 mars 2015 12:15:41 +0000 John Marino wrote: |> | +OPTIONS_DEFINE= PORTS_SSL |> | + |> | +PORTS_SSL_DESC= Build with OpenSSL from ports (instead of base system) |> | + |> | +.include |> | + |> | +.if ${PORT_OPTIONS:MPORTS_SSL} |> | +.if !defined(WITH_OPENSSL_PORT) |> | +IGNORE= the PORTS_SSL option not allowed when WITH_OPENSSL_PORT is |> | not set +.endif |> | +CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX} |> | +.else |> | +.if defined(WITH_OPENSSL_PORT) |> | +IGNORE= the PORTS_SSL option is required when WITH_OPENSSL_PORT is |> | set +.endif |> | +.endif |> |> That seems way overly complicated, why not just do: |> |> .if defined(WITH_OPENSSL_PORT) |> CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX} |> .endif | | | I assume the maintainer wants to preserve the possibility to not include | openssl capability at all... (neither port nor base) Mmmm, well, no, the only thing what you committed does is force the one building the port is to say that he's using, or not, OpenSSL from ports, and have it broken if one choose wrong. -- Mathieu Arnold