Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Jan 2015 20:42:46 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Benjamin Kaduk <bjkfbsd@gmail.com>
Cc:        svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r277803 - projects/clang360-import/lib/clang/include
Message-ID:  <C42296A3-CC47-412D-B925-5708DE45F521@FreeBSD.org>
In-Reply-To: <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com>
References:  <201501271925.t0RJPem3010417@svn.freebsd.org> <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_9980F44F-A17A-4E70-948C-16E12BF38EDD
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 27 Jan 2015, at 20:34, Benjamin Kaduk <bjkfbsd@gmail.com> wrote:
>=20
> On Tue, Jan 27, 2015 at 2:25 PM, Dimitry Andric <dim@freebsd.org> =
wrote:
> Author: dim
> Date: Tue Jan 27 19:25:39 2015
> New Revision: 277803
> URL: https://svnweb.freebsd.org/changeset/base/277803
>=20
> Log:
>   Change the path to clang's private headers.  Upstream has always =
stored
>   these in $LIBDIR/clang/$VERSION/include, instead of our previous =
custom
>   location in /usr/include/clang/$VERSION.  This allows us to drop yet
>   another FreeBSD-specific patch.
>=20
> Modified:
>   projects/clang360-import/lib/clang/include/Makefile
>=20
> Modified: projects/clang360-import/lib/clang/include/Makefile
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- projects/clang360-import/lib/clang/include/Makefile Tue Jan 27 =
18:58:24 2015        (r277802)
> +++ projects/clang360-import/lib/clang/include/Makefile Tue Jan 27 =
19:25:39 2015        (r277803)
> @@ -8,7 +8,7 @@ LLVM_SRCS=3D ${.CURDIR}/../../../contrib/l
>=20
>  .PATH: ${LLVM_SRCS}/tools/clang/lib/Headers
>=20
> -INCSDIR=3D${INCLUDEDIR}/clang/3.6.0
> +INCSDIR=3D/usr/lib/clang/3.6.0/include
>=20
> Is it a good idea to hardcode /usr/lib/ here?

I know of no other way to make sure that it does *not* get installed
into /usr/lib32 during the install32 stage.  This was the same problem
I encountered for lib/libclang_rt/Makefile.inc.

If you know a nicer way to ensure that, please let me know. :)

-Dimitry


--Apple-Mail=_9980F44F-A17A-4E70-948C-16E12BF38EDD
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.26

iEYEARECAAYFAlTH6kAACgkQsF6jCi4glqPtzACfUvA5/7JDS4TIz9ZgJzOiAi0D
DqEAnjQdh96QjY4KIcjgumveNp1OKGcs
=lS38
-----END PGP SIGNATURE-----

--Apple-Mail=_9980F44F-A17A-4E70-948C-16E12BF38EDD--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C42296A3-CC47-412D-B925-5708DE45F521>