From owner-svn-src-all@freebsd.org Sat Sep 14 04:25:38 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 078DCDE28B for ; Sat, 14 Sep 2019 04:25:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46VfZ91nLvz4Tbf for ; Sat, 14 Sep 2019 04:25:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id x4so4761295qtq.8 for ; Fri, 13 Sep 2019 21:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dzlgQ2TTJqzIl4I/hvGx7yZhX/pLQbPRHkztsVs4NPI=; b=zwnlNGF86UXyY8j5pXlRnt+o75KwaovcNiYRBbiJvmgA2Zh18M7ZS0v5M6VhG77Ooz eFTQRh4Q9/rFEFKJPGrC/UEzI19ibREA3hexgHUXe1r14DT0TTi+mknsd9MeH4fhdkH4 fscBnshMriOyDN015s4Uz/T5XmqIr0JT1dhfNGTDQoLy0JCx3t58LVAl5zotvWacW0b5 TnqHmR7sFD95jWDU4Ld6HU1jfJ4RvGmrhWXwjTfeHMgqjvmiXlD9BEtbw6QQrTdRO+Tf J+58GOGtCtuljIGWyeHfGMt2i53U+BsOMh8AM2hzNIwjT/MEpINcbN9tric6BJeQFzuM b8eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dzlgQ2TTJqzIl4I/hvGx7yZhX/pLQbPRHkztsVs4NPI=; b=ITK9ZdJi64ID5bUw7/V2nfl4zVRxmDebAD9lK8o16g+zewJoMvgx1cdImdzyYGtrBV SVuc4QLI0tlfUpszBhgkQ7xfWEhiVvIszxSc4mQF5iqJiadMoF28glFYYJ3X6JWKl5x2 FzQjwY3FvjoI2gJFHl7y5nSrlkLVw4yFxH15pmgjjrrH1M3wpqrF1otDd4VP7Jayh+6k RR2imKPl7u9RUy4hUulP0znrVFou1oUrp47HSc0sqy2UpWEZQ7Ik575usIQvEZ4qH6HW NuUYyIsleKeAkHjwsDZGUQPkI5FAKoZh7y1RLHitO7UONILzLZ79uv8ZdvFR23wrDLfa o1NQ== X-Gm-Message-State: APjAAAUGP0PDftztG9Np8DPwjCp3FGe/Un4r4Gco9CKV/D6DCmdU48EI KItrWnb7+czaFq9E37prMLkAXl+eMexnl2Az6aem1Q== X-Google-Smtp-Source: APXvYqxw3cJupsv8yQaG1nndLr6ta2gkv7RiJAmxpndjF1ygUc5iD2Z9cZLpnSjCNklvbd1fYcyJrf4Yll+BypbXHSw= X-Received: by 2002:ac8:1208:: with SMTP id x8mr6112428qti.32.1568435135586; Fri, 13 Sep 2019 21:25:35 -0700 (PDT) MIME-Version: 1.0 References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> <20190914041041.GA97181@server.rulingia.com> In-Reply-To: <20190914041041.GA97181@server.rulingia.com> From: Warner Losh Date: Fri, 13 Sep 2019 22:25:23 -0600 Message-ID: Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline To: Peter Jeremy Cc: Baptiste Daroussin , Charlie Li , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 46VfZ91nLvz4Tbf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=zwnlNGF8; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.39 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[a.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.89)[ip: (-9.43), ipnet: 2607:f8b0::/32(-2.70), asn: 15169(-2.24), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; SUSPICIOUS_RECIPS(1.50)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 04:25:38 -0000 On Fri, Sep 13, 2019, 10:11 PM Peter Jeremy wrote: > On 2019-Sep-13 16:33:15 -0400, Charlie Li wrote: > >Baptiste Daroussin wrote: > >> Author: bapt > >> Date: Fri Sep 13 06:50:02 2019 > >> New Revision: 352275 > >> URL: https://svnweb.freebsd.org/changeset/base/352275 > >> > >> Log: > >> Update libedit to a snapshot from 2019-09-10 > >> Reviewed by: Yuichiro Naito > >> MFC after: 3 weeks > >> Differential Revision: https://reviews.freebsd.org/D21584 > >> > >I posted in phab but repeating here, this breaks the build on (at least) > >aarch64: > > It breaks the build on arm and arm64 only. > > wint_t is int on all platforms: > sys/sys/_types.h: > typedef int __ct_rune_t; /* arg type for ctype funcs */ > typedef __ct_rune_t __wint_t; /* wint_t (see above) */ > > but wchar_t varies between unsigned and signed: > $ grep '__wchar_t' sys/*/include/_types.h > sys/arm/include/_types.h:typedef unsigned int ___wchar_t; > sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; > sys/mips/include/_types.h:typedef int ___wchar_t; > sys/powerpc/include/_types.h:typedef int ___wchar_t; > sys/riscv/include/_types.h:typedef int ___wchar_t; > sys/sparc64/include/_types.h:typedef int ___wchar_t; > sys/x86/include/_types.h:typedef int ___wchar_t; > > Looking back into history, it looks like the "unsigned" is part > of the ARM EABI. > We should confirm that. It is definitely part of the OABI stuff, but EABI was supposed to fix differences like this... Warner > -- > Peter Jeremy >