From owner-svn-src-head@FreeBSD.ORG Mon Oct 22 03:06:54 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
by hub.freebsd.org (Postfix) with ESMTP id 63AEAB26;
Mon, 22 Oct 2012 03:06:54 +0000 (UTC)
(envelope-from eadler@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
by mx1.freebsd.org (Postfix) with ESMTP id 4B8EB8FC0A;
Mon, 22 Oct 2012 03:06:54 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9M36sTM017722;
Mon, 22 Oct 2012 03:06:54 GMT (envelope-from eadler@svn.freebsd.org)
Received: (from eadler@localhost)
by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9M36s7c017719;
Mon, 22 Oct 2012 03:06:54 GMT (envelope-from eadler@svn.freebsd.org)
Message-Id: <201210220306.q9M36s7c017719@svn.freebsd.org>
From: Eitan Adler <eadler@FreeBSD.org>
Date: Mon, 22 Oct 2012 03:06:53 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Subject: svn commit: r241846 - in head/games: bcd caesar
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2012 03:06:54 -0000
Author: eadler
Date: Mon Oct 22 03:06:53 2012
New Revision: 241846
URL: http://svn.freebsd.org/changeset/base/241846
Log:
bcd isn't installed setuid.
caesar isn't installed setuid.
For the archaeologists:
it seems this call originally came from NetBSD PR 5970 and 5945
PR: 172566
Submitted by: Erik Cederstrand <erik@cederstrand.dk>
Approved by: cperciva
MFC after: 3 days
Modified:
head/games/bcd/bcd.c
head/games/caesar/caesar.c
Modified: head/games/bcd/bcd.c
==============================================================================
--- head/games/bcd/bcd.c Mon Oct 22 03:00:43 2012 (r241845)
+++ head/games/bcd/bcd.c Mon Oct 22 03:06:53 2012 (r241846)
@@ -129,9 +129,6 @@ main(int argc, char **argv)
{
char cardline[80];
- /* revoke setgid privileges */
- setgid(getgid());
-
/*
* The original bcd prompts with a "%" when reading from stdin,
* but this seems kind of silly. So this one doesn't.
Modified: head/games/caesar/caesar.c
==============================================================================
--- head/games/caesar/caesar.c Mon Oct 22 03:00:43 2012 (r241845)
+++ head/games/caesar/caesar.c Mon Oct 22 03:06:53 2012 (r241846)
@@ -82,9 +82,6 @@ main(int argc, char **argv)
char *inbuf;
int obs[26], try, winner;
- /* revoke setgid privileges */
- setgid(getgid());
-
if (argc > 1)
printit(argv[1]);