Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Oct 2012 03:06:53 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r241846 - in head/games: bcd caesar
Message-ID:  <201210220306.q9M36s7c017719@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Mon Oct 22 03:06:53 2012
New Revision: 241846
URL: http://svn.freebsd.org/changeset/base/241846

Log:
  bcd isn't installed setuid.
  caesar isn't installed setuid.
  
  For the archaeologists:
  it seems this call originally came from NetBSD PR 5970 and 5945
  
  PR:		172566
  Submitted by:	Erik Cederstrand <erik@cederstrand.dk>
  Approved by:	cperciva
  MFC after:	3 days

Modified:
  head/games/bcd/bcd.c
  head/games/caesar/caesar.c

Modified: head/games/bcd/bcd.c
==============================================================================
--- head/games/bcd/bcd.c	Mon Oct 22 03:00:43 2012	(r241845)
+++ head/games/bcd/bcd.c	Mon Oct 22 03:06:53 2012	(r241846)
@@ -129,9 +129,6 @@ main(int argc, char **argv)
 {
 	char cardline[80];
 
-	/* revoke setgid privileges */
-	setgid(getgid());
-
 	/*
 	 * The original bcd prompts with a "%" when reading from stdin,
 	 * but this seems kind of silly.  So this one doesn't.

Modified: head/games/caesar/caesar.c
==============================================================================
--- head/games/caesar/caesar.c	Mon Oct 22 03:00:43 2012	(r241845)
+++ head/games/caesar/caesar.c	Mon Oct 22 03:06:53 2012	(r241846)
@@ -82,9 +82,6 @@ main(int argc, char **argv)
 	char *inbuf;
 	int obs[26], try, winner;
 
-	/* revoke setgid privileges */
-	setgid(getgid());
-
 	if (argc > 1)
 		printit(argv[1]);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210220306.q9M36s7c017719>