Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Dec 2018 15:26:46 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Christoph Moench-Tegeder <cmt@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r486763 - head/graphics/gexiv2/files
Message-ID:  <20181206152646.GA93198@FreeBSD.org>
In-Reply-To: <201812061452.wB6EqFCB073812@repo.freebsd.org>
References:  <201812061452.wB6EqFCB073812@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 06, 2018 at 02:52:15PM +0000, Christoph Moench-Tegeder wrote:
> New Revision: 486763
> URL: https://svnweb.freebsd.org/changeset/ports/486763
> 
> Log:
>   gexiv2: fix build with non-clang compilers
>   
> [...]
> --- head/graphics/gexiv2/files/patch-gexiv2_meson.build	Thu Dec  6 14:26:22 2018	(r486762)
> +++ head/graphics/gexiv2/files/patch-gexiv2_meson.build	Thu Dec  6 14:52:15 2018	(r486763)
> @@ -1,11 +1,16 @@
> ---- gexiv2/meson.build.orig	2018-11-23 19:55:20 UTC
> -+++ gexiv2/meson.build
> -@@ -35,7 +35,7 @@ install_headers(gexiv2_headers, subdir :
> +--- gexiv2/meson.build.orig	2018-12-01 18:58:21.005598000 +0100
> ++++ gexiv2/meson.build	2018-12-01 19:01:56.566055000 +0100
> +@@ -35,10 +35,10 @@

May I wonder why did you squash correct +++/--- lines format?  Please use
``make makepatch'' when (re)generating patches next time.

Additionally, you might want to get into habbit of doing "svn diff" before
commit, it would have shown that.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181206152646.GA93198>