From nobody Sat Apr 4 09:35:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fnr6h4xNgz6YKfZ for ; Sat, 04 Apr 2026 09:35:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fnr6h1sLJz3Sxh for ; Sat, 04 Apr 2026 09:35:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775295324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cnpg3oIlHmhe6Ley3masFnvhJ6hjZE1FxYviaR2Rx+0=; b=mfNczqS/dt6bf+Wa1OyJ4ROZJDBZj4QYsdaMMKpxc8BK4LIuXLnFk4Zg50ZiVDD21JJKEj v0ZxEqPrxDkaQsOA1Dy3slnwx4NNuPXw01Bw3ayz5n7EsJRqNge3LtV8BFpVJxehRj3pEm r6bgyldvhsiZ0Qix22938GZLd8Sq3ULSRe1f+3h/3+XGmhYYHUtp5TlaNNnr77BYuW8aiS N+A0c6i9v2Qxm5ZWR0XdB2n6wFRQiTqgoWfdOdg31nGsRQ5yOwZpueRHrRlvpCG//r9kMP Vi3czSrijvN0ImDf0qp6igwnF9x7lNG6yVk4AnH+bX0P79gJW4z3gTNADDuoBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775295324; a=rsa-sha256; cv=none; b=MH/0eDHzX6ThdjFcIeKRJmk3F032L0s2aZKQ6LM1lK+G2MJvAADC7N4FXFzJfQ7KJ7fzmj PNYZ9yYEhBU2elNxufc9IDsc0mvACK4NljAt/pbDHx25dsIGmehPaZWBXetBGzIJBObN29 jPpkCTipzosSisJ7hihlThOPDqyyN38vwo4wmZpAIHYzflYwwauRvluS8qZI1kG90sXITk Yf3WSLB6qaN+93zQquMY1y0o8pWJpy3UFm72Jp43UxFUac6U6KGOS9x1F4G7XL9aUp/NZP HzCjkbIYB9LnOqR0quGLa2u0L6dwoZlAtu+uphCxAC1jYzyk2R6C5WsSp11irg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775295324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cnpg3oIlHmhe6Ley3masFnvhJ6hjZE1FxYviaR2Rx+0=; b=NCXrWtW9pbya1/V1R6JxqjL3mBsfjBT4m8sZ3ayQwSVynxNEyTFmFMm6VMW8wN0OZIMT7s io2DnlJh7k7nfB5s/yZ+nnYL2enbiuMbQJa4PyR5xnOff8cq+HsonTOmIIGbXuaRvp/SXK ZNZjVGB3VC9HLmElQMKFzGUia1CM0g7k2WU7FkIMZSPHj/OMh1VxzXDg3yAzP4/HgOgMPI wjhAPw4CrWfvjZ7blxrV7axUHa5MbJnQbz2//9/q5izmZ2hSTU7ALYuWKpQ3T2gr2BzPrF msuFYQaJLTzNc22Gbm0JXIoQ2yF+Qnct1yyF2PoVOp3ZJdcTe4l1ON1WyVd1hg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fnr6h1CFNz1RpP for ; Sat, 04 Apr 2026 09:35:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b84a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 04 Apr 2026 09:35:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Salychev Subject: git: 26b27a828803 - stable/15 - dpaa2: Perform bus_dma pre-write sync before enqueue operation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dsl X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 26b27a82880347828205700a5d54a0516a3f15b1 Auto-Submitted: auto-generated Date: Sat, 04 Apr 2026 09:35:24 +0000 Message-Id: <69d0db5c.3b84a.e505543@gitrepo.freebsd.org> The branch stable/15 has been updated by dsl: URL: https://cgit.FreeBSD.org/src/commit/?id=26b27a82880347828205700a5d54a0516a3f15b1 commit 26b27a82880347828205700a5d54a0516a3f15b1 Author: Dmitry Salychev AuthorDate: 2026-03-28 18:57:45 +0000 Commit: Dmitry Salychev CommitDate: 2026-04-04 09:28:09 +0000 dpaa2: Perform bus_dma pre-write sync before enqueue operation Without a proper synchronization payload of the egress TCP segments can be corrupted as tuexen@ described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292006#c31. This patch is indirectly related to 292006 because a properly enabled and announced support for the TX checksum offloading hides potentially corrupted frame payload. PR: 292006 Reported by: tuexen@ Reviewed by: tuexen@ Tested by: dsl@, tuexen@ Differential Revision: https://reviews.freebsd.org/D56144 MFC after: 3 days (cherry picked from commit 5812415bee55a9063508b02fda9418b0eadb0bb4) --- sys/dev/dpaa2/dpaa2_ni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/dpaa2/dpaa2_ni.c b/sys/dev/dpaa2/dpaa2_ni.c index 98a6c6047188..9389c6fff31a 100644 --- a/sys/dev/dpaa2/dpaa2_ni.c +++ b/sys/dev/dpaa2/dpaa2_ni.c @@ -3006,6 +3006,9 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, goto err_unload; } + bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); + bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); + /* TODO: Enqueue several frames in a single command */ for (int i = 0; i < DPAA2_NI_ENQUEUE_RETRIES; i++) { /* TODO: Return error codes instead of # of frames */ @@ -3015,9 +3018,6 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, } } - bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); - bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); - if (rc != 1) { fq->chan->tx_dropped++; goto err_unload;