From owner-freebsd-current Tue Dec 28 15:40:53 1999 Delivered-To: freebsd-current@freebsd.org Received: from canonware.com (canonware.com [207.20.242.18]) by hub.freebsd.org (Postfix) with SMTP id E836615522 for ; Tue, 28 Dec 1999 15:40:50 -0800 (PST) (envelope-from jasone@canonware.com) Received: (qmail 76301 invoked by uid 1001); 28 Dec 1999 23:38:06 -0000 Date: Tue, 28 Dec 1999 15:38:06 -0800 From: Jason Evans To: Daniel Eischen Cc: Soren Schmidt , Kenneth Wayne Culver , freebsd-current@FreeBSD.ORG Subject: Re: the nist port Message-ID: <19991228153806.R39990@sturm.canonware.com> References: <199912282040.VAA45252@freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from eischen@vigrid.com on Tue, Dec 28, 1999 at 05:34:34PM -0500 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Dec 28, 1999 at 05:34:34PM -0500, Daniel Eischen wrote: > On Tue, 28 Dec 1999, Soren Schmidt wrote: > > It seems Kenneth Wayne Culver wrote: > > > I can't get the nist port to compile: > > > c++ -g -O2 -Wall -DDO_NIST -DPACKAGE=\"ac3dec\" -DVERSION=\"0.5.5\" > > > -I../../inc -c bitstream.c -o bitstream.o > > > In file included from decode.h:24, > > > from bitstream.c:27: > > > ../../inc/athread.hh: In function `int athr_setschedparam(pthread *, int, > > > sched_param *)': > > > ../../inc/athread.hh:150: implicit declaration of function `int > > > pthread_setschedparam(...)' > > > ../../inc/athread.hh: In function `int athr_getschedparam(pthread *, int > > > *, sched_param *)': > > > ../../inc/athread.hh:151: implicit declaration of function `int > > > pthread_getschedparam(...)' > > > bitstream.c: In function `uint_32 bitstream_get(bitstream_t *, long > > > unsigned int)': > > > > Uhm, seems like we need to define _POSIX_THREAD_PRIORITY_SCHEDULING now > > to get the prototypes for these, add: > > > > #ifdef __FreeBSD__ > > #define _POSIX_THREAD_PRIORITY_SCHEDULING > > #endif > > > > Hey, these _POSIX_THREAD_XXXX definitions used to be in pthread.h. > It looks like they were removed from version 1.16 of pthread.h: > > revision 1.16 > date: 1999/12/16 21:53:38; author: jasone; state: Exp; lines: +1 -18 > Move POSIX feature constants from pthread.h to unistd.h, as required by > 1003.1c-1995. > > Undefine _POSIX_THREAD_SAFE_FUNCTIONS, since we do not implement all of the > necessary interfaces. At least getgrgid_r(), getrnam_r(), getpwuid_r(), > getpwnam_r(), getc_unlocked(), getchar_unlocked(), putc_unlocked(), > and putchar_unlocked() are missing. Due to a likely typo in 1003.1c-1995, > we are not technically allowed to define _POSIX_THREADS without defining > _POSIX_THREAD_SAFE_FUNCTIONS, but either way we're non-compliant, so I'm > leaving _POSIX_THREADS defined. > > They're not in unistd.h either. This is a FreeBSD bug. They're in sys/unistd.h, which is included by unistd.h. That should be just fine, and that location appears to be consistent with our other POSIX macro definitions. Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message