From owner-svn-src-all@freebsd.org Sat Dec 17 14:49:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34E60C84915; Sat, 17 Dec 2016 14:49:47 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFC861220; Sat, 17 Dec 2016 14:49:46 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::e9b4:ef6:9a02:eea4] (unknown [IPv6:2001:7b8:3a7:0:e9b4:ef6:9a02:eea4]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 68E0214F77; Sat, 17 Dec 2016 15:49:44 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_DABF726A-3F8C-4D2C-AD1C-32FAB42E9344"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r310138 - head/lib/libc/stdio From: Dimitry Andric In-Reply-To: <00BFA847-B26A-453A-87DB-D5A55C1FAA38@FreeBSD.org> Date: Sat, 17 Dec 2016 15:49:32 +0100 Cc: Baptiste Daroussin , "Conrad E. Meyer" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <0BDD9ECA-AF91-4CA7-AA5D-DC7AD36AE531@FreeBSD.org> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net> <00BFA847-B26A-453A-87DB-D5A55C1FAA38@FreeBSD.org> To: David Chisnall X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 14:49:47 -0000 --Apple-Mail=_DABF726A-3F8C-4D2C-AD1C-32FAB42E9344 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 17 Dec 2016, at 12:46, David Chisnall wrote: >=20 > On 16 Dec 2016, at 19:31, Baptiste Daroussin wrote: >>=20 >> Other than that, it makes more difficult to use vanilla gcc with out = userland. >> and it is adding more complexity to be able to build freebsd from a = non freebsd >> system which some people are working on. >=20 > Why? You=E2=80=99ll get some spurious warnings about printf, but = that=E2=80=99s all. Unfortunately, we compile large parts of the tree with -Werror. Thus, "spurious warnings" will break the build, leaving the user two options: disabling -Wformat warnings, or disabling -Werror altogether, neither of which are very recommendable. As far as I know, there is no -Wno-error-on-undefined-printf-specifiers. It would also be hard to implement, since after any undefined specifiers have been encountered, you cannot reason about the following ones anymore either. IMHO, if people want to use non-standard specifiers, let them define their own almost_printf_but_not_quite() functions, and forgo any format checking. -Dimitry --Apple-Mail=_DABF726A-3F8C-4D2C-AD1C-32FAB42E9344 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhVUIgACgkQsF6jCi4glqM6fACfawgq5SWhp1hoeRBAVu7hm2Jg 630AoNMdHKE8hODUtV3luLceSLLoruvB =kEd7 -----END PGP SIGNATURE----- --Apple-Mail=_DABF726A-3F8C-4D2C-AD1C-32FAB42E9344--