From owner-freebsd-hackers Wed Oct 1 04:59:58 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id EAA08765 for hackers-outgoing; Wed, 1 Oct 1997 04:59:58 -0700 (PDT) Received: from gatekeeper.tsc.tdk.com (root@gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id EAA08729; Wed, 1 Oct 1997 04:59:15 -0700 (PDT) Received: from sunrise.gv.tsc.tdk.com (root@sunrise.gv.tsc.tdk.com [192.168.241.191]) by gatekeeper.tsc.tdk.com (8.8.4/8.8.4) with ESMTP id EAA27860; Wed, 1 Oct 1997 04:58:57 -0700 (PDT) Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194]) by sunrise.gv.tsc.tdk.com (8.8.5/8.8.5) with ESMTP id EAA09539; Wed, 1 Oct 1997 04:58:56 -0700 (PDT) Received: (from gdonl@localhost) by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id EAA14360; Wed, 1 Oct 1997 04:58:55 -0700 (PDT) From: Don Lewis Message-Id: <199710011158.EAA14360@salsa.gv.tsc.tdk.com> Date: Wed, 1 Oct 1997 04:58:55 -0700 In-Reply-To: David Greenman "Re: FreeBSD TCP stack and RST processing [subj changed]" (Oct 1, 4:51am) X-Mailer: Mail User's Shell (7.2.6 alpha(3) 7/19/95) To: dg@root.com, Don Lewis Subject: Re: FreeBSD TCP stack and RST processing [subj changed] Cc: Richard Jones , pst@freebsd.org, hackers@freebsd.org, bugs@freebsd.org Sender: owner-freebsd-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Oct 1, 4:51am, David Greenman wrote: } Subject: Re: FreeBSD TCP stack and RST processing [subj changed] } ---------------------------- } revision 1.52 } date: 1996/10/07 04:32:39; author: pst; state: Exp; lines: +23 -13 } Increase robustness of FreeBSD against high-rate connection attempt } denial of service attacks. It sure looks to me like it does the opposite :-( I'd either back this patch out entirely, or only do the ack check. A third possibility would be to always call tcp_drop() if TH_RST is set in the TCPS_SYN_RECEIVED state, no matter if TH_ACK is set or not. I looked at {Open,Net}BSD and neither of them picked up this change. --- Truck