From owner-svn-src-all@freebsd.org Fri Jan 26 22:22:22 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 763E1ECCA23; Fri, 26 Jan 2018 22:22:22 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 241276895C; Fri, 26 Jan 2018 22:22:22 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1F054217B3; Fri, 26 Jan 2018 22:22:22 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w0QMMMYo038002; Fri, 26 Jan 2018 22:22:22 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w0QMMLnt037996; Fri, 26 Jan 2018 22:22:21 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201801262222.w0QMMLnt037996@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Fri, 26 Jan 2018 22:22:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r328449 - in head/stand: i386/gptboot mips/beri/loader mips/uboot powerpc/kboot uboot/common uboot/lib X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: in head/stand: i386/gptboot mips/beri/loader mips/uboot powerpc/kboot uboot/common uboot/lib X-SVN-Commit-Revision: 328449 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 22:22:22 -0000 Author: imp Date: Fri Jan 26 22:22:21 2018 New Revision: 328449 URL: https://svnweb.freebsd.org/changeset/base/328449 Log: Tag unreachable places as such. I left the while (1); in place since in this context we want to busy wait to stop. Suggested by: pfg@ Modified: head/stand/i386/gptboot/gptboot.c head/stand/mips/beri/loader/main.c head/stand/mips/uboot/conf.c head/stand/powerpc/kboot/main.c head/stand/uboot/common/main.c head/stand/uboot/lib/glue.c Modified: head/stand/i386/gptboot/gptboot.c ============================================================================== --- head/stand/i386/gptboot/gptboot.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/i386/gptboot/gptboot.c Fri Jan 26 22:22:21 2018 (r328449) @@ -365,6 +365,7 @@ void exit(int x) { while (1); + __unreachable(); } static void Modified: head/stand/mips/beri/loader/main.c ============================================================================== --- head/stand/mips/beri/loader/main.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/mips/beri/loader/main.c Fri Jan 26 22:22:21 2018 (r328449) @@ -193,6 +193,7 @@ abort(void) printf("error: loader abort\n"); while (1); + __unreachable(); } void @@ -201,6 +202,7 @@ exit(int code) printf("error: loader exit\n"); while (1); + __unreachable(); } void @@ -209,6 +211,7 @@ longjmperror(void) printf("error: loader longjmp error\n"); while (1); + __unreachable(); } time_t Modified: head/stand/mips/uboot/conf.c ============================================================================== --- head/stand/mips/uboot/conf.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/mips/uboot/conf.c Fri Jan 26 22:22:21 2018 (r328449) @@ -105,6 +105,7 @@ abort(void) printf("error: loader abort\n"); while (1); + __unreachable(); } void @@ -113,6 +114,7 @@ longjmperror(void) printf("error: loader longjmp error\n"); while (1); + __unreachable(); } int debug = 1; Modified: head/stand/powerpc/kboot/main.c ============================================================================== --- head/stand/powerpc/kboot/main.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/powerpc/kboot/main.c Fri Jan 26 22:22:21 2018 (r328449) @@ -131,6 +131,7 @@ void exit(int code) { while (1); /* XXX: host_exit */ + __unreachable(); } void Modified: head/stand/uboot/common/main.c ============================================================================== --- head/stand/uboot/common/main.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/uboot/common/main.c Fri Jan 26 22:22:21 2018 (r328449) @@ -526,7 +526,8 @@ command_reboot(int argc, char *argv[]) ub_reset(); printf("Reset failed!\n"); - while(1); + while (1); + __unreachable(); } COMMAND_SET(devinfo, "devinfo", "show U-Boot devices", command_devinfo); Modified: head/stand/uboot/lib/glue.c ============================================================================== --- head/stand/uboot/lib/glue.c Fri Jan 26 21:51:13 2018 (r328448) +++ head/stand/uboot/lib/glue.c Fri Jan 26 22:22:21 2018 (r328449) @@ -187,7 +187,8 @@ ub_reset(void) { syscall(API_RESET, NULL); - while (1); /* Can't tag syscall as __dead2 */ + while (1); /* fallback if API_RESET failed */ + __unreachable(); } static struct mem_region mr[UB_MAX_MR];