From owner-cvs-src@FreeBSD.ORG  Mon Sep 19 14:33:45 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 47CDA16A41F;
	Mon, 19 Sep 2005 14:33:45 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DC7C143D45;
	Mon, 19 Sep 2005 14:33:44 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8JEV2lu022901;
	Mon, 19 Sep 2005 08:31:02 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 19 Sep 2005 08:31:11 -0600 (MDT)
Message-Id: <20050919.083111.123550990.imp@bsdimp.com>
To: ru@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20050919054051.GB65954@ip.net.ua>
References: <200509182051.j8IKpYGU073493@repoman.freebsd.org>
	<20050919054051.GB65954@ip.net.ua>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 19 Sep 2005 08:31:02 -0600 (MDT)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c if_edvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2005 14:33:45 -0000

In message: <20050919054051.GB65954@ip.net.ua>
            Ruslan Ermilov <ru@freebsd.org> writes:
: About the commonality...  Usually foo_stop() (which is called first in
: foo_detach() if you were talking about the detach) disables interrupts,
: so foo_intr() doesn't usually happen.  From reading the code, I see the
: same holds true for ed(4).

Wrong.  Foo_intr() does still happen because other devices can
generate interrupts...

: OTOH, it was shown that on some SMP machines it's possible to get a
: call to foo_intr() after foo_stop() has been called by foo_shutdown(),
: which will lead to a panic in most of the drivers.  See kern/85005 and
: kern/62889 for some examples.
: 
: I think the generic solution to this problem should be to return from
: foo_intr() quickly if IFF_DRV_RUNNING is not set.

Only if we free ifp after we tear down the interrupts.

Warner