Date: Thu, 20 Feb 1997 15:22:06 -0800 (PST) From: mpp@freebsd.org To: FreeBSD-gnats-submit@freebsd.org Subject: bin/2785: callbootd uses an unitialized variable Message-ID: <199702202322.PAA14789@freefall.freebsd.org> Resent-Message-ID: <199702202330.PAA15418@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 2785
>Category: bin
>Synopsis: callbootd uses an unitialized variable
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 20 15:30:01 PST 1997
>Last-Modified:
>Originator: Mike Pritchard
>Organization:
Mike Pritchard
>Release: FreeBSD 3.0-current
>Environment:
>Description:
While apply another coesmetic patch to bootparamd/callbootd,
I noticed that callbootd uses an unitialized variable.
>How-To-Repeat:
Compile bootparamd with COPTS=-Wall
>Fix:
I think the following patch should fix the problem, but someone who
actually knows something about how bootparamd works should review it.
Index: callbootd/callbootd.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/bootparamd/callbootd/callbootd.c,v
retrieving revision 1.4
diff -u -r1.4 callbootd.c
--- callbootd.c 1997/01/14 07:10:38 1.4
+++ callbootd.c 1997/02/20 23:16:30
@@ -88,12 +88,11 @@
if ( ! broadcast ) {
clnt = clnt_create(server,BOOTPARAMPROG, BOOTPARAMVERS, "udp");
- }
-
- if ( clnt == NULL ) {
- fprintf (stderr, "%s: could not contact bootparam server on host %s\n",
+ if ( clnt == NULL ) {
+ fprintf (stderr, "%s: could not contact bootparam server on host %s\n",
argv[0], server);
- exit (1);
+ exit (1);
+ }
}
switch (argc) {
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702202322.PAA14789>