From nobody Fri Apr 17 12:20:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxv8l51HWz6ZgHq; Fri, 17 Apr 2026 12:20:07 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxv8l2q91z4F9L; Fri, 17 Apr 2026 12:20:07 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776428407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2xb0equwvNir78cb+WVCvNvL/ezqHxghwCybR4RcwRA=; b=IhyYqmSBA3nzDFc4/ufT3R1Q40BGvASiIQOM+EJroXpnZ6rOxNxQlKkbgKYfEdesIKRdZv eYljPAUXhsAYvJgXBgXWondKut6eH/8br0sa7MZ3q+6Zy62msrZBkEbV8YmJolgjQReB8b kKqDzLq7NVS3d/N1ksb9YtLmMdhCKc+osy3VPz94PFhz+6EyQdZ9ju2wrsuA43FNwaNcGK OGAXG6/lG7Tup7071QgXrXhjXqo5+itAtwSV+vWn8a5a+wv0RKUajRyEkugyPEXcgh83Ys ACRcWmpH9kuUHI3GLH0J/RRfTXoo1dPYoALKFlLdlV6eXFDDi5AP33sZBynR8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776428407; a=rsa-sha256; cv=none; b=whhFzFjvTKfnwecfn3XyEbkDpyGo37io180G5lpFQazA5j0VtKGjG6bDc6s+K+HbV0bm79 fUWb9p/ESScZBvvC4fsTkKTvDDDtAv6DZ9HhUn0jZXJiK8j4QKOH9ulWMtLYFDg4OCHB6L ckMbGXXP1PKdey7CcYc4drZaftt3Q1LePDq58oJNy48CEPmft70iHz06ug4qNCLM97BVnp 3bL64v8gnnKNl/QyNdTDoAMZMzEoWdMUlA6RTHwq+rDnAyaeHjZhLXZeFBtf3KqBUIAtiE Sy+ygUoqNh0uBuvoXCtq0BXGG4Wu69z9Rotd6yf55ILsw3eum/A8F7Lr4m1qVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776428407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2xb0equwvNir78cb+WVCvNvL/ezqHxghwCybR4RcwRA=; b=byqI2eY63bjHsnAAnY9eV5kVRkIxkz0NoVQ6KYi3/2cAvHrZojWtWj8RZ6YL1KRbgKrXvx jvX1z6zN5Mu3VtLiO15NMIaBVjXxkPxRj57OBeHQJ1LIcEo7j+CyhQMslLPWZK96APVPEc TA7RBHIXv1XSdFH6uNMq5mgO8YyiuUpweHIJ5HEhcHMBIhFebwErAHUAsbOBN6HRvtZmrV eDxZUNpKtG/ObRyMoALMWn/IZqWd4/2xzqyRBxc9vk9vJaUTKensvAp6QiCYKJjNzanDEi B4uztVI8UD+Tyt28+gcymDQIuAqsLN5V2hNvV6OTUvYGilX63D8HpA4Q8J76ng== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fxv8k6tZqzqyB; Fri, 17 Apr 2026 12:20:06 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Fri, 17 Apr 2026 08:20:04 -0400 From: Mark Johnston To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, imp@freebsd.org Subject: Re: git: 1491fe8f864a - main - uart/pci: support 16550A PCI serial devices Message-ID: References: <69c640e1.1fc2b.4542bc24@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 17, 2026 at 11:28:05AM +0200, Roger Pau Monné wrote: > On Thu, Apr 16, 2026 at 04:17:03PM -0400, Mark Johnston wrote: > > On Fri, Mar 27, 2026 at 08:33:37AM +0000, Roger Pau Monné wrote: > > > The branch main has been updated by royger: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1491fe8f864af5af37e83f1d12459905fb6097fd > > > > > > commit 1491fe8f864af5af37e83f1d12459905fb6097fd > > > Author: Roger Pau Monné > > > AuthorDate: 2026-03-26 10:01:57 +0000 > > > Commit: Roger Pau Monné > > > CommitDate: 2026-03-27 08:26:32 +0000 > > > > > > uart/pci: support 16550A PCI serial devices > > > > > > Expand the current check to also attach the ns8250 driver to devices > > > reporting as 16550A. This has been tested to work on a real device. > > > > > > From an inspection of the code in the ns8250 driver it seems like it should > > > support up to 16950A devices, but I don't have hardware to ensure that, > > > hence be conservative with the change. > > > > I have a system which hangs in uart_bus_probe() after this change. It > > has a 2-port UART PCI card installed: > > > > puc0@pci0:6:0:0: class=0x070002 rev=0x00 hdr=0x00 vendor=0x1415 device=0xc158 subvendor=0x1415 subdevice=0xc158 > > vendor = 'Oxford Semiconductor Ltd' > > device = 'OXPCIe952 Dual Native 950 UART' > > class = simple comms > > subclass = UART > > > > Normally puc(4) attaches to it and creates two child uart devices: > > > > puc0 > > Interrupt request lines: > > 0x11 > > pcib7 memory window: > > 0x84000000-0x841fffff > > 0x84200000-0x843fffff > > 0x84400000-0x84403fff > > uart2 > > puc0 I/O memory mapping: > > 0x84401000-0x844011ff > > puc0 port numbers: > > 0x1 > > uart3 > > puc0 I/O memory mapping: > > 0x84401200-0x844013ff > > puc0 port numbers: > > 0x2 > > > > After this change, though, uart(4) tries to probe the device directly > > and hangs. Presumably we still want to exclude at least multi-port > > devices here? > > Hm, I see, sorry, I didn't think changing the UART version > compatibility would cause this. What about using BUS_PROBE_SPECIFIC > vs BUS_PROBE_GENERIC? > > If the PCI device matches a device in the pci_ns8250_ids array we > return SPECIFIC, otherwise if it's a generic PCI serial device we > return GENERIC, thus allowing the puc driver to take over it. > > Could you please give a try to the patch below. This patch allowed my system to boot, thank you.