From owner-p4-projects@FreeBSD.ORG Mon Mar 23 06:17:16 2015 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id DF85C782; Mon, 23 Mar 2015 06:17:15 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A160D780 for ; Mon, 23 Mar 2015 06:17:15 +0000 (UTC) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:1900:2254:2068::682:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8C58429B for ; Mon, 23 Mar 2015 06:17:15 +0000 (UTC) Received: from skunkworks.freebsd.org ([127.0.1.74]) by skunkworks.freebsd.org (8.14.9/8.14.9) with ESMTP id t2N6HFIO048968 for ; Mon, 23 Mar 2015 06:17:15 GMT (envelope-from jmg@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.9/8.14.9/Submit) id t2N6HFwm048965 for perforce@freebsd.org; Mon, 23 Mar 2015 06:17:15 GMT (envelope-from jmg@freebsd.org) Date: Mon, 23 Mar 2015 06:17:15 GMT Message-Id: <201503230617.t2N6HFwm048965@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to jmg@freebsd.org using -f From: John-Mark Gurney Subject: PERFORCE change 1207528 for review To: Perforce Change Reviews Precedence: bulk X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.18-1 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 06:17:16 -0000 http://p4web.freebsd.org/@@1207528?ac=10 Change 1207528 by jmg@jmg_pciehp on 2015/03/23 06:16:43 This gets pciehp working again.. turns out that you call pcib_ functions on the bus, which is dev here, not on the pcib device... You are accessing the parent's ivars, which here, pcib is the parent.. This means I can push stuff down again.. Sponsored by: The FreeBSD Foundation Affected files ... .. //depot/projects/pciehotplug/sys/dev/pci/pci.c#6 edit Differences ... ==== //depot/projects/pciehotplug/sys/dev/pci/pci.c#6 (text+ko) ==== @@ -3517,8 +3517,8 @@ int first_func; pcib = device_get_parent(dev); - domain = pcib_get_domain(pcib); - busno = pcib_get_bus(pcib); + domain = pcib_get_domain(dev); + busno = pcib_get_bus(dev); /* * Try to detect a device at slot 0, function 0. If it exists, try to