From owner-freebsd-net@freebsd.org  Sat Feb 10 16:33:30 2018
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6147FF09568
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sat, 10 Feb 2018 16:33:30 +0000 (UTC)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D10FE86752
 for <freebsd-net@freebsd.org>; Sat, 10 Feb 2018 16:33:29 +0000 (UTC)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w1AGXR0D035992;
 Sat, 10 Feb 2018 08:33:27 -0800 (PST)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd-rwg@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w1AGXRSY035991;
 Sat, 10 Feb 2018 08:33:27 -0800 (PST) (envelope-from freebsd-rwg)
From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201802101633.w1AGXRSY035991@pdx.rh.CN85.dnsmgr.net>
Subject: Re: Review: Fix regression that did not allow "route change" that
 didn't re-specify the gateway
In-Reply-To: <CAFMmRNxjvDRm+PXaFK8wyahYHaRTERR+kBH1=y6NbGz+5UGdig@mail.gmail.com>
To: Ryan Stone <rysto32@gmail.com>
Date: Sat, 10 Feb 2018 08:33:26 -0800 (PST)
CC: freebsd-net <freebsd-net@freebsd.org>
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Feb 2018 16:33:30 -0000

> A change a while back (r264986) broke the ability to change a route's
> parameters if the gateway wasn't explicitly specified again.  For

Was the a feature by accident or design?  As the man page does not
say that "gateway" is optional on a change command, it shows it
as a required parameter.

> example, you used to be able to run "route change 10.0.0.0/8 -mtu
> 9000" to change the MTU without having to provide the gateway IP to
> the command.  I have a review open to restore the existing behaviour.
                                                    ^^^^^^^^
prior?

> In cases where the gateway is not specified, the gateway on the route
> remains unchanged.
> 
> Anyone interested in reviewing this change should add themselves as a
> reviewer to https://reviews.freebsd.org/D14291.

I requested a man page update in the review,
but did not mark it as blocking.

> Thanks,
> Ryan

-- 
Rod Grimes                                                 rgrimes@freebsd.org