From owner-freebsd-audit Wed Jul 25 17:44: 7 2001 Delivered-To: freebsd-audit@freebsd.org Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by hub.freebsd.org (Postfix) with ESMTP id 2F8F937B405 for ; Wed, 25 Jul 2001 17:43:58 -0700 (PDT) (envelope-from sheldonh@starjuice.net) Received: from sheldonh (helo=axl.seasidesoftware.co.za) by axl.seasidesoftware.co.za with local-esmtp (Exim 3.31 #1) id 15PZGa-0001fS-00; Thu, 26 Jul 2001 02:44:40 +0200 From: Sheldon Hearn To: David Hill Cc: audit@freebsd.org Subject: Re: STD*_FILENO patches #2 In-reply-to: Your message of "Tue, 24 Jul 2001 09:47:44 +0200." <6134.995960864@axl.seasidesoftware.co.za> Date: Thu, 26 Jul 2001 02:44:40 +0200 Message-ID: <6413.996108280@axl.seasidesoftware.co.za> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 24 Jul 2001 09:47:44 +0200, Sheldon Hearn wrote: > > Ok, I fixed those > > http://www.phobia.ms/patches/diffs.tar.gz > > I'll take a look at these and commit them some time before Friday. Right, they're running through a buildworld now. Some comments: 1) Please submit patches in a uniform way. Some were context diffs, some unified diffs. Some used full pathnames, some relative pathnames. The patchset wasn't as easy to apply as it could have been. 2) I've ommitted your rcorder patch, because rcorder is vendor software. We put vendor code in places other than contrib/ just to confuse the shit out of our contributors. Please submit that patch to the NetBSD maintainer for rcorder, Luke Mewburn . 3) Well spotted on usr.sbin/ctm/ctm_rmail/options.h. This file is already missing all sorts of includes, so adding would have introduced inconsistency. :-) Thanks for the contribution. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message