From owner-freebsd-current Wed Mar 26 09:44:56 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA29580 for current-outgoing; Wed, 26 Mar 1997 09:44:56 -0800 (PST) Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA29543 for ; Wed, 26 Mar 1997 09:44:37 -0800 (PST) Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id KAA04465; Wed, 26 Mar 1997 10:44:10 -0700 (MST) Date: Wed, 26 Mar 1997 10:44:10 -0700 (MST) Message-Id: <199703261744.KAA04465@rocky.mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Mike Pritchard Cc: nate@mt.sri.com (Nate Williams), current@freebsd.org Subject: Re: dumpfs patch for review In-Reply-To: <199703261647.IAA22621@freefall.freebsd.org> References: <199703260551.WAA01493@rocky.mt.sri.com> <199703261647.IAA22621@freefall.freebsd.org> X-Mailer: VM 6.22 under 19.14 XEmacs Lucid Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > It's not pretty, and I'm not sure how to 'correctly' printout the value > > of the new fs_id line, but since no-one else appears to be doing > > anything about it here's my attempt at fixing the broken tree. > > > > If no one objects I'll commit this tomorrow after enough people have > > time to review it. > > fs_id[0] is a time_t value, and probably should be printed as such. > is it the time that the file system was "randomized", either > by newfs or fsirand. Ahh, OK. > fd_id[1] is a random number Ok, here's round two. Nate -------- Index: dumpfs.c =================================================================== RCS file: /home/CVS/src/sbin/dumpfs/dumpfs.c,v retrieving revision 1.6 diff -c -r1.6 dumpfs.c *** dumpfs.c 1997/03/11 12:12:26 1.6 --- dumpfs.c 1997/03/26 17:43:32 *************** *** 127,132 **** --- 127,134 ---- dev_bsize = afs.fs_fsize / fsbtodb(&afs, 1); printf("magic\t%x\ttime\t%s", afs.fs_magic, ctime(&afs.fs_time)); + printf("fsid\t%d\trndtime\t%s", + afs.fs_id[1], ctime((time_t *)&afs.fs_id[0])); printf("cylgrp\t%s\tinodes\t%s\n", afs.fs_postblformat == FS_42POSTBLFMT ? "static" : "dynamic", afs.fs_inodefmt < FS_44INODEFMT ? "4.2/4.3BSD" : "4.4BSD"); *************** *** 143,153 **** afs.fs_frag, afs.fs_fragshift, afs.fs_fsbtodb); printf("cpg\t%d\tbpg\t%d\tfpg\t%d\tipg\t%d\n", afs.fs_cpg, afs.fs_fpg / afs.fs_frag, afs.fs_fpg, afs.fs_ipg); ! printf("minfree\t%d%%\toptim\t%s\tmaxcontig %d\tmaxbpg\t%d\n", ! afs.fs_minfree, afs.fs_optim == FS_OPTSPACE ? "space" : "time", ! afs.fs_maxcontig, afs.fs_maxbpg); ! printf("rotdelay %dms\theadswitch %dus\ttrackseek %dus\trps\t%d\n", ! afs.fs_rotdelay, afs.fs_headswitch, afs.fs_trkseek, afs.fs_rps); printf("ntrak\t%d\tnsect\t%d\tnpsect\t%d\tspc\t%d\n", afs.fs_ntrak, afs.fs_nsect, afs.fs_npsect, afs.fs_spc); printf("symlinklen %d\ttrackskew %d\tinterleave %d\tcontigsumsize %d\n", --- 145,154 ---- afs.fs_frag, afs.fs_fragshift, afs.fs_fsbtodb); printf("cpg\t%d\tbpg\t%d\tfpg\t%d\tipg\t%d\n", afs.fs_cpg, afs.fs_fpg / afs.fs_frag, afs.fs_fpg, afs.fs_ipg); ! printf("minfree\t%d%%\toptim\t%s\n", ! afs.fs_minfree, afs.fs_optim == FS_OPTSPACE ? "space" : "time"); ! printf("maxcontig %d\tmaxbpg\t%d\trotdelay %dms\trps\t%d\n", ! afs.fs_maxcontig, afs.fs_maxbpg, afs.fs_rotdelay, afs.fs_rps); printf("ntrak\t%d\tnsect\t%d\tnpsect\t%d\tspc\t%d\n", afs.fs_ntrak, afs.fs_nsect, afs.fs_npsect, afs.fs_spc); printf("symlinklen %d\ttrackskew %d\tinterleave %d\tcontigsumsize %d\n",