From owner-freebsd-current@FreeBSD.ORG  Tue Apr 22 21:32:29 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DAB81065674
	for <freebsd-current@freebsd.org>; Tue, 22 Apr 2008 21:32:29 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 916968FC1B
	for <freebsd-current@freebsd.org>; Tue, 22 Apr 2008 21:32:28 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 3060E17105;
	Tue, 22 Apr 2008 21:32:26 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m3MLWQQ6013384;
	Tue, 22 Apr 2008 21:32:26 GMT (envelope-from phk@critter.freebsd.dk)
To: d@delphij.net
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 22 Apr 2008 14:29:00 MST."
	<480E589C.8010108@delphij.net> 
Date: Tue, 22 Apr 2008 21:32:26 +0000
Message-ID: <13383.1208899946@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: freebsd-current@freebsd.org, Ivan Voras <ivoras@freebsd.org>
Subject: Re: Http Accept filters (accf_http) 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Apr 2008 21:32:29 -0000

In message <480E589C.8010108@delphij.net>, Xin LI writes:

>| Does anyone know why accf_accept is disabled by default in the ports'
>| stock Apache 2.2 (it's disabled in the default config files)? I thought
>| it was because it was dangerous or flawed for some reason, though (at
>| least for light loads comparable to those of OP) it seems to work fine.

I think adding them to the apache is OK, as long as apache fails
gracefully if they are not present in the kernel.

>Yes, I wonder that too.  Personally I think it might be a good idea to
>just bind accf_http and accf_data into GENERIC, as I always add them
>into kernel configuration at my company...  My $0.02

No, GENERIC should not be bloated when it can be effortlessly loaded
as a KLD.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.