From owner-p4-projects@FreeBSD.ORG Sat May 3 21:02:08 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id BD3E437B401; Sat, 3 May 2003 21:02:06 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C99437B404; Sat, 3 May 2003 21:02:06 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7702F43FB1; Sat, 3 May 2003 21:02:05 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h44424A7034110; Sat, 3 May 2003 22:02:04 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 03 May 2003 22:01:39 -0600 (MDT) Message-Id: <20030503.220139.44793868.imp@bsdimp.com> To: jmallett@freebsd.org From: "M. Warner Losh" In-Reply-To: <200305030240.h432elND072264@repoman.freebsd.org> References: <200305030240.h432elND072264@repoman.freebsd.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: perforce@freebsd.org Subject: Re: PERFORCE change 30435 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 May 2003 04:02:08 -0000 In message: <200305030240.h432elND072264@repoman.freebsd.org> Juli Mallett writes: : http://perforce.freebsd.org/chv.cgi?CH=30435 : : Change 30435 by jmallett@jmallett_dalek on 2003/05/02 19:40:13 : : Erk, remove redundant call to cp0_status_read. : : Affected files ... : : .. //depot/projects/mips/sys/mips/include/cpufunc.h#8 edit : : Differences ... : : ==== //depot/projects/mips/sys/mips/include/cpufunc.h#8 (text+ko) ==== : : @@ -38,7 +38,6 @@ : { : register_t s; : : - s = mips_cp0_status_read(); : mips_cp0_status_write((s = mips_cp0_status_read()) & ~MIPS_SR_IE); : return (s); : } Sure this is really redundant and not there for some weird mips box's pipeline delay requirements? Warner