From owner-svn-src-head@FreeBSD.ORG Mon Jul 12 15:08:46 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9ECCF106597A; Mon, 12 Jul 2010 15:08:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id DD3848FC18; Mon, 12 Jul 2010 15:08:42 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 902FB46B8A; Mon, 12 Jul 2010 11:08:42 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D4D708A050; Mon, 12 Jul 2010 11:08:41 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Date: Mon, 12 Jul 2010 11:08:12 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100217; KDE/4.4.5; amd64; ; ) References: <201007121427.o6CERnOJ022550@svn.freebsd.org> In-Reply-To: <201007121427.o6CERnOJ022550@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201007121108.12564.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 12 Jul 2010 11:08:41 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r209948 - head/sys/nfsclient X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2010 15:08:46 -0000 On Monday, July 12, 2010 10:27:49 am John Baldwin wrote: > Author: jhb > Date: Mon Jul 12 14:27:49 2010 > New Revision: 209948 > URL: http://svn.freebsd.org/changeset/base/209948 > > Log: > A previous change moved the GETATTR RPC for open() calls that hit in the > name cache up into nfs_lookup() instead of nfs_open(). Continue this > trend by flushing the attribute cache for leaf nodes in nfs_lookup() during > an open() if we do a LOOKUP RPC. For NFSv3 this should generally be a NOP > as the attributes are flushed before fetching the post-op attributes from > the LOOKUP RPC which most (all?) NFSv3 servers provide, so the post-op > attributes should populate the cache. > > Now all NFS open() calls will always clear the cached attributes during the > nfs_lookup() prior to nfs_open() in the !NMODIFIED case to provide CTOC. > As a result, we can remove the conditional flushing of the attribute > cache from nfs_open(). One benefit is that we can now remove td_syscalls which added extra overhead to each system call. -- John Baldwin