From owner-freebsd-hackers Wed Sep 20 11: 7:52 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [207.154.226.10]) by hub.freebsd.org (Postfix) with ESMTP id 090F037B422; Wed, 20 Sep 2000 11:07:50 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1000) id 868B92B230; Wed, 20 Sep 2000 13:07:44 -0500 (CDT) Date: Wed, 20 Sep 2000 11:07:44 -0700 From: Paul Saab To: Matt Dillon Cc: Danny Braniss , Mike Smith , freebsd-hackers@FreeBSD.ORG Subject: Re: diskless workstation Message-ID: <20000920110744.A55357@elvis.mu.org> References: <20000920093025.A53255@elvis.mu.org> <200009201802.e8KI2Fe45459@earth.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200009201802.e8KI2Fe45459@earth.backplane.com>; from dillon@earth.backplane.com on Wed, Sep 20, 2000 at 11:02:15AM -0700 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Matt Dillon (dillon@earth.backplane.com) wrote: > A quick review of the code seems to indicate that this is indeed a bug. > As far as I can tell, the IN_CLASS*() macros assume host order. e.g. > from /usr/include/netinet/in.h: > > #define IN_CLASSA(i) (((u_int32_t)(i) & 0x80000000) == 0) > > Since s_addr is in network byte order, the conversion is necessary. If > this fixes Danny's problems, and doesn't break anyone else (Paul?), I'd > say it should be committed. After playing with it somemore, I agree.. It doesn't break for small networks, which is what I was testing on. I'll commit the fix. paul To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message