From owner-freebsd-ports  Mon Sep 25 13:40:37 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from smtp10.atl.mindspring.net (smtp10.atl.mindspring.net [207.69.200.246])
	by hub.freebsd.org (Postfix) with ESMTP
	id 02C2A37B424; Mon, 25 Sep 2000 13:40:32 -0700 (PDT)
Received: from silvia.hip.berkeley.edu (sji-ca1-01.ix.netcom.com [209.109.232.1])
	by smtp10.atl.mindspring.net (8.9.3/8.8.5) with ESMTP id QAA21607;
	Mon, 25 Sep 2000 16:40:26 -0400 (EDT)
Received: (from asami@localhost)
	by silvia.hip.berkeley.edu (8.11.0/8.11.0) id e8PKeNG30599;
	Mon, 25 Sep 2000 13:40:23 -0700 (PDT)
	(envelope-from asami)
To: Peter Pentchev <roam@orbitel.bg>
Cc: Kris Kennaway <kris@FreeBSD.org>, ports@FreeBSD.org
Subject: Re: unbreak devel/cdk port, raise minor PORTREVISION issue
References: <Pine.BSF.4.21.0009250305480.31922-100000@freefall.freebsd.org> <vqclmwgslq0.fsf@silvia.hip.berkeley.edu> <20000925154442.D31322@ringwraith.office1.bg>
From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami)
Date: 25 Sep 2000 13:40:20 -0700
In-Reply-To: Peter Pentchev's message of "Mon, 25 Sep 2000 15:44:42 +0300"
Message-ID: <vqcg0moryrv.fsf@silvia.hip.berkeley.edu>
Lines: 27
X-Mailer: Gnus v5.7/Emacs 20.7
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

 * From: Peter Pentchev <roam@orbitel.bg>

 * Uhm.. For the other 51 ports, your fix probably did The Right Thing(tm);
 * and thank you :)
 * 
 * However, the devel/cdk port is still broken :)  It has DISTNAME=cdk,
 * yet the dist tarball unpacks into cdk-4.9.10/; that's why this particular
 * port needs WRKSRC=${WRKDIR}/${PORTNAME}-${PORTVERSION}.

I'm not sure what you are talking about.  I did fix the cdk port and
it no longer defines DISTNAME as the result.  Are you sure you are
looking at the right version? :>

By the way, I did verify that my "fix" works for most ports (including
cdk) before the commit..

 :
 * > The real reason of the devel/cdk breakage is the
 * > WRKSRC=${WRKDIR}/${PKGNAME} line in its Makefile.  Instead of defining
 * > DISTNAME and WRKSRC, it should have just used DISTFILES.  It will
 * > reduce the line count too.
 * > 
 * > I did a search and this was not the only port that defined WRKSRC as
 * > ${WRKDIR}/${PKGNAME}.  I committed fixes to all 52 of them just now.
 :

Satoshi


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message