From owner-p4-projects@FreeBSD.ORG Sat Dec 15 01:17:15 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
id C6E6816A473; Sat, 15 Dec 2007 01:17:14 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id 480E116A469
for <perforce@freebsd.org>; Sat, 15 Dec 2007 01:17:14 +0000 (UTC)
(envelope-from qingli@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
[IPv6:2001:4f8:fff6::29])
by mx1.freebsd.org (Postfix) with ESMTP id 24FC513C448
for <perforce@freebsd.org>; Sat, 15 Dec 2007 01:17:14 +0000 (UTC)
(envelope-from qingli@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBF1HEWl083245
for <perforce@freebsd.org>; Sat, 15 Dec 2007 01:17:14 GMT
(envelope-from qingli@freebsd.org)
Received: (from perforce@localhost)
by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBF1HEWt083242
for perforce@freebsd.org; Sat, 15 Dec 2007 01:17:14 GMT
(envelope-from qingli@freebsd.org)
Date: Sat, 15 Dec 2007 01:17:14 GMT
Message-Id: <200712150117.lBF1HEWt083242@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
qingli@freebsd.org using -f
From: Qing Li <qingli@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc:
Subject: PERFORCE change 130920 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Dec 2007 01:17:15 -0000
http://perforce.freebsd.org/chv.cgi?CH=130920
Change 130920 by qingli@FreeBSD-newarp on 2007/12/15 01:17:05
Forgot to initialize the callout in a newly created nd6 entry, causing the kernel to crash
when callout_reset() is called on that entry for transition to the STALE state.
Affected files ...
.. //depot/projects/arp-v2/src/sys/netinet6/nd6.c#3 edit
Differences ...
==== //depot/projects/arp-v2/src/sys/netinet6/nd6.c#3 (text+ko) ====
@@ -804,8 +804,10 @@
if (create)
flags |= LLE_CREATE;
ln = lla_lookup(ifp, flags, (struct sockaddr *)&sin6);
- if ((ln != NULL) && (flags & LLE_CREATE))
+ if ((ln != NULL) && (flags & LLE_CREATE)) {
ln->ln_state = ND6_LLINFO_NOSTATE;
+ callout_init(&ln->ln_timer_ch, 0);
+ }
return (ln);
}