From owner-freebsd-arch Sat Mar 24 0:39:52 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 018DD37B71B; Sat, 24 Mar 2001 00:39:39 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA24659; Sat, 24 Mar 2001 19:39:32 +1100 Date: Sat, 24 Mar 2001 19:38:57 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Julian Elischer Cc: John Baldwin , Archie Cobbs , arch@FreeBSD.ORG Subject: Re: Critical Regions Round II In-Reply-To: <3ABC105D.E01C0842@elischer.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 23 Mar 2001, Julian Elischer wrote: > John Baldwin wrote: > > Archie said: > > > Shouldn't these be, e.g., > > > > > > i386_disable_intr(), i386_enable_intr() > > > > > > and > > > > > > ia64_enable_intr(), ia64_disable_intr() > > No, this code should not be used outside of sys/${MACHINE_ARCH}, which is > > mostly how things were (aside from broken things like the joy driver) before > > SMPng. > > I think the names should include either md_ or I386_ as a leadin so that people > who are 'copying' to make their own drivers a made fully aware > of what is going on. The MD names should simply be accessible in MI code. There are currently too many of them in . A few broken drivers access MD interfaces directly: grepping for 'include.*i386/' gives: dev/aha/aha_mca.c:#include dev/ar/if_ar_isa.c:#include dev/ar/if_ar_isa.c:#include dev/ar/if_ar_isa.c:#include dev/asr/asr.c:#include dev/asr/i2oadptr.h:# include "i386/pci/i2omsg.h" dev/asr/i2obscsi.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */ dev/asr/i2oexec.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */ dev/asr/i2oexec.h:# include "i386/pci/i2outil.h" dev/asr/i2omsg.h:# include "i386/pci/i2otypes.h" dev/asr/i2otypes.h:# include "i386/pci/i2odep.h" dev/asr/i2outil.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */ dev/asr/osd_util.h:# include "i386/isa/dpt_osd_defs.h" dev/asr/osd_util.h:# include "i386/isa/dpt_osd_defs.h" dev/asr/sys_info.h:# include "i386/isa/dpt_osd_util.h" dev/asr/sys_info.h:# include "i386/isa/dpt_osd_util.h" dev/buslogic/bt_mca.c:#include dev/ct/bshw_machdep.c:#include dev/ct/bshw_machdep.c:#include dev/ct/bshw_machdep.c:#include dev/ct/bshw_machdep.c:#include dev/ct/ct.c:#include dev/ct/ct.c:#include dev/ct/ct.c:#include dev/ct/ct_isa.c:#include dev/ct/ct_isa.c:#include dev/ct/ct_isa.c:#include dev/ct/ct_isa.c:#include dev/ct/ctvar.h:#include dev/dgb/dgb.c:#include dev/dgb/dgm.c:#include dev/dpt/dpt_control.c:#include dev/ep/if_ep_isa.c:#include dev/fe/if_fe.c:#include dev/fe/if_fe_cbus.c:#include dev/fe/if_fe_isa.c:#include dev/fe/if_fe_pccard.c:#include dev/ie/if_ie.c:#include dev/ie/if_ie.c:#include dev/ie/if_ie.c:#include dev/ie/if_ie.c:#include dev/lnc/if_lnc_pc98.c:#include dev/ncv/ncr53c500.c:#include dev/ncv/ncr53c500.c:#include dev/ncv/ncr53c500.c:#include dev/ncv/ncr53c500.c:#include dev/ncv/ncr53c500.c:#include dev/ncv/ncr53c500_pccard.c:#include dev/nsp/nsp.c:#include dev/nsp/nsp.c:#include dev/nsp/nsp.c:#include dev/nsp/nsp_pccard.c:#include dev/pdq/pdq_ifsubr.c:#include dev/stg/tmc18c30.c:#include dev/stg/tmc18c30.c:#include dev/stg/tmc18c30.c:#include dev/stg/tmc18c30_pccard.c:#include Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message