From owner-cvs-src@FreeBSD.ORG Tue Aug 22 08:22:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE42E16A4DA; Tue, 22 Aug 2006 08:22:54 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECDAA43D72; Tue, 22 Aug 2006 08:22:31 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id F18095E6B; Tue, 22 Aug 2006 12:22:29 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id B852B5DE9; Tue, 22 Aug 2006 12:22:29 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.6/8.13.6) id k7M8Mbl3042278; Tue, 22 Aug 2006 12:22:37 +0400 (MSD) (envelope-from ru) Date: Tue, 22 Aug 2006 12:22:37 +0400 From: Ruslan Ermilov To: Pyun YongHyeon Message-ID: <20060822082237.GC41304@rambler-co.ru> References: <200608220232.k7M2WmCr080275@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/" Content-Disposition: inline In-Reply-To: <200608220232.k7M2WmCr080275@repoman.freebsd.org> User-Agent: Mutt/1.5.12-2006-07-14 X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2006 08:22:55 -0000 --61jdw2sOBCFtR2d/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Pyun, On Tue, Aug 22, 2006 at 02:32:48AM +0000, Pyun YongHyeon wrote: > yongari 2006-08-22 02:32:48 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/em if_em.c=20 > Log: > It seems that em(4) misses Tx completion interrupts under certain > conditions. The cause of missing Tx completion interrupts comes from > Tx interrupt moderation mechanism(delayed interrupts) or chipset bug. > If Tx interrupt moderation mechanism is the cause of false watchdog > timeout error we should have to fix all device drivers that have Tx > interrupt moderation capability. We may need more investigation > for this issue. Anyway, the fix is the same for both cases. > =20 > This should fix occasional watchdog timeout errors seen on a few > systems. > =20 > Reported by: -net, Patrick M. Hausen < hausen AT punkt DOT de > > Tested by: Patrick M. Hausen < hausen AT punkt DOT de > > =20 > Revision Changes Path > 1.133 +12 -0 src/sys/dev/em/if_em.c >=20 I agree this is a less painful way to recover, but it's still a watchdog and it slows down the performance when it happens. After this commit, if there's a moderate number of missing Tx completion interrupts (for some reason), even a diagnostic message won't be printed. This is bad -- users will "seem" to have working but slow systems, without any indication of what causes this slowness. I think a diagnostic message should still be printed in this case, and adapter->watchdog_events should still be incrementd, we just don't need to reinit the chip in this case. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --61jdw2sOBCFtR2d/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE6r7NqRfpzJluFF4RAqE2AJ9bagwyvLIIiYDYBRTGJTVmMJJxwACfU42J FjyNVKdSO1yTMbg2gOzjrFM= =iC2j -----END PGP SIGNATURE----- --61jdw2sOBCFtR2d/--