From nobody Fri Aug 18 05:22:39 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRqyC61Bbz4qhFT; Fri, 18 Aug 2023 05:22:43 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRqyC12fFz4MZ3; Fri, 18 Aug 2023 05:22:43 +0000 (UTC) (envelope-from unkadoug@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6bcbb0c40b1so511318a34.3; Thu, 17 Aug 2023 22:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692336161; x=1692940961; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gG47YfGq3EvxBFom/G071PmwJZZ7B6de85MX14T/SAI=; b=g9Fl6WomOqy19Gd0J0cy2kVmvqnJZUSEK1gch3uj1C4+uhRk7CA3zpqxHRtQcsjIso F84O8nA3Rb/wykAdVUaT/7wa+q/XiUQp4vZPwhhJF6sc9OKtfd3gXqiK/FoxD6srounS 0occ11iuKU7WvZBlWejeYk2zQBWNZoBgWfkwdnuLHwGkFObSCLGv2+bBdAKmuODKz5N8 Vcw3L0f6IvwDZjsLOmC2u984gHGiqyz3wagalmF7svoictyhUWo6xbwIuOLH1CFjhQOG wtY9MU0duw2gPdBJnuB5C1Q6ny4cx6zKlzTGDbfPu/q6mkl/iiRB0lLpxFlPlz2yytRR +z+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692336161; x=1692940961; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gG47YfGq3EvxBFom/G071PmwJZZ7B6de85MX14T/SAI=; b=hp5ukd/ZoOuR4HE+Gz4QYrAYU7VP/aX/hGL1ItOB8Hcowv2xtxfceO63B5BPB+7X1r E+iMa9YxyfGuC3nvbQ0mYc9NvmUQtuPV6FkpjTeEY0kLVK6prC7U89rpDA9wFgtqHPap nMzjkD0dLH9sUq1dAKngH88R540/GO8TFzTIcUxKOkBjVDInHlb2j6UnRcWDhvvMxMfJ +YJa/0gaUAAjRUAT0EXfm67pQyZbyiK/Cfg04t/2MzdqDvSlusHWrz5fhGN/Q8n+ucvR zFIWdug3ZfM4HJn+dd16gyjYRFOlxRaLvoOvBjwqdbThmR4noxZ2xLAnHU5FRaJS3s71 yVDQ== X-Gm-Message-State: AOJu0Yz6jm8o/yLg08so0iHuJkobi0mkSy5sb59t+MtFYe41ZmRkzci9 TDYPGe3QSqHOZNXOFINRWFyOl0wtg8JD6A== X-Google-Smtp-Source: AGHT+IGtkgj2IDPSWbbhORYxxxgSHYnqc8fK5KOglr+UyNXVbdlFO6PP/z18Ih31lxO6CdnoA+po6Q== X-Received: by 2002:a05:6830:1609:b0:6b5:eb27:ce24 with SMTP id g9-20020a056830160900b006b5eb27ce24mr1368351otr.38.1692336161479; Thu, 17 Aug 2023 22:22:41 -0700 (PDT) Received: from [108.254.203.202] (108-254-203-202.lightspeed.hstntx.sbcglobal.net. [108.254.203.202]) by smtp.gmail.com with ESMTPSA id h15-20020a9d798f000000b006b954f7f422sm545055otm.6.2023.08.17.22.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 22:22:41 -0700 (PDT) Message-ID: <77da3b75-5f7e-5c4b-caf3-4285bb87c6fe@gmail.com> Date: Fri, 18 Aug 2023 00:22:39 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: git: b80ea452375f - main - LinuxKPI: implement mul_u64_u64_div_u64() Content-Language: en-US To: Kyle Evans , "Bjoern A. Zeeb" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202308180121.37I1LPTc024071@gitrepo.freebsd.org> <3e99dded-478b-8bb7-cbe0-78587040c3d9@FreeBSD.org> From: Doug Moore In-Reply-To: <3e99dded-478b-8bb7-cbe0-78587040c3d9@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4RRqyC12fFz4MZ3 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] It remains the case, for me at least, that KASSERT is not defined where it is used in math64.h, and so compilation still fails. On 8/18/23 00:14, Kyle Evans wrote: > On 8/18/23 00:09, Kyle Evans wrote: >> On 8/17/23 20:21, Bjoern A. Zeeb wrote: >>> The branch main has been updated by bz: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=b80ea452375f52a3ab7d82a9aef10da0d89985d9 >>> >>> commit b80ea452375f52a3ab7d82a9aef10da0d89985d9 >>> Author:     Bjoern A. Zeeb >>> AuthorDate: 2023-05-16 20:55:00 +0000 >>> Commit:     Bjoern A. Zeeb >>> CommitDate: 2023-08-18 01:20:39 +0000 >>> >>>      LinuxKPI: implement mul_u64_u64_div_u64() >>>      Implement mul_u64_u64_div_u64() for an updated iwlwifi driver >>> (though >>>      we do not yet use it there; it is used for in-kernel ptp on wifi). >>>      Sponsored by:   The FreeBSD Foundation >>>      Submitted by:   cperciva >>>      MFC after:      10 days >>>      Reviewed by:    cperciva, dwmalone >>>      Differential Revision: https://reviews.freebsd.org/D40120 >> >> This broke buildkernel on multiple architectures, it seems: >> https://ci.freebsd.org/tinderbox/ >> >> I've confirmed that reverting this commit fixes it. I'd be lying if I >> claimed to understand what's going on: > > I lied; I looked again at the context and realized it was just missing > an extra closing parentheses. I went ahead and hammered it away in > dabbbebcb0f5... > > Thanks, > > Kyle Evans >