From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 5 21:00:10 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0E72106566B for ; Sat, 5 Apr 2008 21:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BE6568FC13 for ; Sat, 5 Apr 2008 21:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m35L0Aih022447 for ; Sat, 5 Apr 2008 21:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m35L0AsY022446; Sat, 5 Apr 2008 21:00:10 GMT (envelope-from gnats) Date: Sat, 5 Apr 2008 21:00:10 GMT Message-Id: <200804052100.m35L0AsY022446@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Olli Hauer Cc: Subject: Re: ports/122469: [patch] options for viewvc] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Olli Hauer List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2008 21:00:11 -0000 The following reply was made to PR ports/122469; it has been noted by GNATS. From: Olli Hauer To: "Philip M. Gollucci" , bug-followup@FreeBSD.org, Olli Hauer Cc: Subject: Re: ports/122469: [patch] options for viewvc] Date: Sat, 05 Apr 2008 22:29:17 +0200 sorry reply was to gnats not bug-followup so i sent again. Hi Philip, > 1) Needs a PORTVERSION bump, the default depends changed. > 2) Also, the final include needs to change to bsd.port.post.mk > from bsd.port.mk > 3) Why not move APACHE into the OPTIONS ? > 4) It might be good to use WITH_APACHE2 not WITH_APACHE in this case > tough this one is my fault :) > > Patch looks good otherwise though. > > Please submit and updated PATCH. > I overlooked to change to (made the same time a patch for cvs2svn). I have not tested viewvc with lighttp but the lighttp site runs trac which depends on python so it can be an option. Regards, olli Here comes the new patch :-) --- Makefile.orig 2008-04-03 04:39:36.000000000 +0200 +++ Makefile 2008-04-05 21:56:48.449919000 +0200 @@ -7,19 +7,36 @@ PORTNAME= viewvc PORTVERSION= 1.0.5 +PORTREVISION= 1 CATEGORIES= devel python MASTER_SITES= http://viewvc.tigris.org/files/documents/3330/41694/ MAINTAINER= pgollucci@p6m7g8.com COMMENT= Web-based Version Control Repository Browsing -RUN_DEPENDS= ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python \ - ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb +OPTIONS= APACHE2 "use Apache as webserver" on \ + LIGHTTPD "use lighttp as webserver" off \ + MYSQL "enable experimental MYSQL support" off \ + MYSQL "enable experimental MYSQL support" off \ + MODPYTHON3 "enable mod_python3 support" off + +.include + +RUN_DEPENDS= ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python USE_PYTHON= yes -.if defined (WITH_APACHE) +.if defined (WITH_APACHE2) USE_APACHE= 2.0+ .endif + +.if defined (WITH_LIGHTTPD) +RUN_DEPENDS+= lighttpd:${PORTSDIR}/www/lighttpd +.endif + +.if defined(WITH_MYSQL) +RUN_DEPENDS+= ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb +.endif + .if defined(WITH_MODPYTHON3) RUN_DEPENDS+= ${APACHEMODDIR}/mod_python.so:${PORTSDIR}/www/mod_python3 .endif @@ -37,4 +54,4 @@ post-install: @${CAT} ${PKGMESSAGE} -.include +.include