Date: Wed, 11 Dec 2002 22:18:40 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.ORG> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: Luigi Rizzo <luigi@FreeBSD.ORG>, Alexander Langer <alex@big.endian.de>, Patrick Soltani <psoltani@ultradns.com>, freebsd-hackers@FreeBSD.ORG Subject: Re: panic: icmp_error: bad length Message-ID: <Pine.NEB.3.96L.1021211221655.2590B-100000@fledge.watson.org> In-Reply-To: <200212120116.aa58562@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
BTW, if this bug exists in 5.0 for the same reasons (or even different
ones), we should try to generate a fix ASAP and get it committed.
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
On Thu, 12 Dec 2002, Ian Dowse wrote:
> In message <20021211170227.A79864@xorpc.icir.org>, Luigi Rizzo writes:
> >the diagnosis looks reasonable, though i do not remember changing
> >anything related to this between 4.6 and 4.7 so i wonder why the
> >error did not appear in earlier versions of the code.
>
> Yes strange - actually, it looks like the "THERE IS NO FUNCTIONAL
> OR EXTERNAL API CHANGE IN THIS COMMIT" commit may be to blame :-)
> Some fragments below.
>
> Ian
>
> bridge.c 1.16.2.2:
> +#ifdef PFIL_HOOKS
> ...
> - * before calling the firewall, swap fields the same as IP does.
> - * here we assume the pkt is an IP one and the header is contiguous
> ...
> - ip = mtod(m0, struct ip *);
> - NTOHS(ip->ip_len);
> - NTOHS(ip->ip_off);
>
> ip_fw.c 1.131.2.34:
> - if (0 && BRIDGED) { /* not yet... */
> - offset = (ntohs(ip->ip_off) & IP_OFFMASK);
> + if (BRIDGED) { /* bridged packets are as on the wire */
> + ip_off = ntohs(ip->ip_off);
> ip_len = ntohs(ip->ip_len);
> } else {
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-hackers" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021211221655.2590B-100000>