From owner-freebsd-hackers@FreeBSD.ORG  Mon May 16 16:25:04 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A2B2916A4CE
	for <freebsd-hackers@freebsd.org>;
	Mon, 16 May 2005 16:25:04 +0000 (GMT)
Received: from crow.addict.de (raven.addict.de [80.86.187.141])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 42DD043D67
	for <freebsd-hackers@freebsd.org>;
	Mon, 16 May 2005 16:25:01 +0000 (GMT)
	(envelope-from j.unger@addict.de)
Received: from crow.addict.de (raven.addict.de [80.86.187.141])
	by crow.addict.de (8.12.9/8.12.6) with ESMTP id j4GGOu3H063521
	for <freebsd-hackers@freebsd.org>;
	Mon, 16 May 2005 18:24:56 +0200 (CEST)
	(envelope-from j.unger@addict.de)
Received: (from unger@localhost)
	by crow.addict.de (8.12.9/8.12.6/Submit) id j4GGOulN063520
	for freebsd-hackers@freebsd.org;
	Mon, 16 May 2005 18:24:56 +0200 (CEST)
X-Authentication-Warning: crow.addict.de: unger set sender to
	j.unger@addict.de using -f
Date: Mon, 16 May 2005 18:24:56 +0200
From: Juergen Unger <j.unger@addict.de>
To: freebsd-hackers@freebsd.org
Message-ID: <20050516162456.GC69167@crow.addict.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
Subject: jails and output of df/mount [PATCH]
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2005 16:25:04 -0000

Hi !

within a jail there are at this time two possibilities
of operation for the syscall getfsstat (which is used e.g.
for the commands 'df' and 'mount'):

security.jail.getfsstatroot_only = 0:
	getfsstat return all filesystems mounted anywhere at the machine

security.jail.getfsstatroot_only = 1:
	getfsstat returns the filesystem where the jail-root is in
	and nothing more (mountpoints within the jails fs-tree are not
	returned)

IMHO is this 2nd one not what is really needed:  If we
have additional filesystems mounted within the jails tree
they should be visible too so that they are shown with
a simple 'df' or 'mount'.

I made a small patch for this which is available at
<http://www.addict.de/unger/fbsd/patch-20050516/>
and should work against CURRENT and RELENG_5_4

Any comments ?  I am not sure if there is locking needed
(mtx_lock, mtx_unlock) around this new piece of code, at this
time ot works for me without locking...
Any other opinions ?  

bye,
  Juergen